Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2604: Ignore query when executing push() #331

Merged
merged 4 commits into from Jul 20, 2018

Conversation

@thomasconner
Copy link
Contributor

commented Jul 18, 2018

Description

All items in the sync queue should be pushed to the backend when given the opportunity. A query should not be allowed to push a subset of the sync queue.

Changes

  • Remove use of a query to push a subset of the sync queue.
  • Update reference docs.

Tests

  • Update related unit tests.

@thomasconner thomasconner self-assigned this Jul 18, 2018

@thomasconner thomasconner requested a review from vinaygahlawat Jul 18, 2018

@vinaygahlawat
Copy link
Contributor

left a comment

LGTM

@thomasconner thomasconner merged commit 2c88174 into master Jul 20, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@thomasconner thomasconner deleted the MLIBZ-2604_Ignore_query_with_push branch Jul 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.