New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2466: Add new device info header information #343

Merged
merged 5 commits into from Aug 9, 2018

Conversation

Projects
None yet
2 participants
@thomasconner
Contributor

thomasconner commented Aug 3, 2018

Description

Implements new X-Kinvey-Device-Info header spec.

Changes

  • Adds X-Kinvey-Device-Info header to outgoing network requests sent to Kinvey.

@thomasconner thomasconner self-assigned this Aug 3, 2018

@thomasconner thomasconner requested a review from heyzooi Aug 3, 2018

os: os.platform(),
ov: os.release(),
sdk: pkg.name,
pv: os.release()

This comment has been minimized.

@vinaygahlawat

vinaygahlawat Aug 6, 2018

Contributor

Why are the OS Version and the Platform Version the same value here?

This comment has been minimized.

@thomasconner

thomasconner Aug 8, 2018

Contributor

This was a mistake. I have fixed it.

@thomasconner thomasconner removed the request for review from heyzooi Aug 8, 2018

@thomasconner

This comment has been minimized.

Contributor

thomasconner commented Aug 9, 2018

I had to make a change to make sure the AndroidManifest.xml is included when the kinvey-nativescript-sdk package is installed. Can you review and approve if everything looks good @vinaygahlawat?

@thomasconner thomasconner merged commit b4e5936 into master Aug 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@thomasconner thomasconner deleted the MLIBZ-2466_Device_Info branch Aug 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment