Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2671: Fix MIC on Microsoft Edge #364

Merged
merged 4 commits into from Oct 4, 2018

Conversation

@thomasconner
Copy link
Contributor

commented Oct 4, 2018

Description

loginWithMIC() uses a popup when on a web browser to display the identity providers login page. An interval is setup to poll this popup for url changes. Once the popup redirects after a successful login the interval will parse the code received from the redirect url and provide it to the SDK.

While the user is attempting to login, the url of the popup is on a different domain of the hosted application that initiated the login. This causes an error when checking the url of the popup that has to be handled and thrown out.

This change handles the error specific thrown by Microsoft Edge when trying to access the url for the popup.

Changes

  • Handle the specific error thrown by Microsoft Edge for loginWithMIC()

Tests

  • This was tested manually on Microsoft Edge running on a Windows 10 VM and Google Chrome. It is not possible at this time to automate this test. loginWithMIC() worked correctly after I made this change.

@thomasconner thomasconner self-assigned this Oct 4, 2018

@thomasconner thomasconner requested a review from vinaygahlawat Oct 4, 2018

@@ -17,7 +17,7 @@ export class Popup extends EventEmitter {
this.emit('loadstart', event);
this.emit('load', event);
} catch (error) {
if (error.code !== global.DOMException.SECURITY_ERR) {
if (error.code !== global.DOMException.SECURITY_ERR && error.message.indexOf('Permission Denied') !== -1) {

This comment has been minimized.

Copy link
@vinaygahlawat

vinaygahlawat Oct 4, 2018

Contributor

Please add a comment to point out what portion of this check is specific to Microsoft Edge.

This comment has been minimized.

Copy link
@thomasconner

thomasconner Oct 4, 2018

Author Contributor

I added the comment

@thomasconner thomasconner merged commit 890bc59 into master Oct 4, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@thomasconner thomasconner deleted the MLIBZ-2671_Fix_Edge_MIC branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.