Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2496: loginWithMIC() should work with the default AuthorizationGrant if null is provided #372

Merged
merged 3 commits into from Oct 18, 2018

Conversation

@thomasconner
Copy link
Contributor

commented Oct 17, 2018

Description

  1. Try to login with MIC, submitting null for the AuthorizationGrant:
Kinvey.User.loginWithMIC(redirectUrl, null, { version: 'v2' })

Expected Result: The default AuthorizationGrant is used and the user is logged in
Actual Result: The following error:

Error
      at new KinveyError (http://localhost:64320/packages/kinvey-html5-sdk/dist/kinvey-html5-sdk.js:19384:16)
      at http://localhost:64320/packages/kinvey-html5-sdk/dist/kinvey-html5-sdk.js:32751:15
      at tryCatch (http://localhost:64320/packages/kinvey-html5-sdk/dist/kinvey-html5-sdk.js:967:12)
      at invokeCallback (http://localhost:64320/packages/kinvey-html5-sdk/dist/kinvey-html5-sdk.js:982:13)
      at http://localhost:64320/packages/kinvey-html5-sdk/dist/kinvey-html5-sdk.js:728:16
      at MutationObserver.flush (http://localhost:64320/packages/kinvey-html5-sdk/dist/kinvey-html5-sdk.js:677:5)

Changes

  • Use the default AuthorizationGrant if null is provided
  • Update integration test to submit null

@thomasconner thomasconner self-assigned this Oct 17, 2018

@thomasconner thomasconner requested a review from vinaygahlawat Oct 17, 2018

@thomasconner thomasconner merged commit f5ada27 into master Oct 18, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@thomasconner thomasconner deleted the MLIBZ-2496_default_authorization_grant branch Oct 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.