Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2732: Fix multiple messages being received when PubNub is reconnected #389

Merged
merged 1 commit into from Feb 12, 2019
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

@@ -77,7 +77,7 @@ export class LiveService {
return this.registerUser(user)
.then((pubnubConfig) => {
// const copy = extend({}, pubnubConfig);
const pubnubClient = new PubNub(pubnubConfig);
const pubnubClient = new PubNub(Object.assign({ dedupeOnSubscribe: true }, pubnubConfig));
This conversation was marked as resolved by vinaygahlawat

This comment has been minimized.

Copy link
@vinaygahlawat

vinaygahlawat Feb 11, 2019

Contributor

Where does the pubnubConfig originally come from? If it is something that we create internally, should we just add this flag in before initializing the Pubnub client with it?

This comment has been minimized.

Copy link
@thomasconner

thomasconner Feb 12, 2019

Author Contributor

The pubnubConfig is sent from the API call that is made to register a user for live service.

const listener = new PubNubListener();
this.initialize(pubnubClient, listener);
// return copy;
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.