New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that prevents using delta fetch with a query #83

Merged
merged 1 commit into from Dec 8, 2016

Conversation

Projects
None yet
4 participants
@thomasconner
Contributor

thomasconner commented Dec 6, 2016

Description

This PR fixes a bug that prevents using delta fetch with a query.

Changes

  • Use setter to set skip and limit properties for a query.
  • Update unit tests for delta fetch.
@codecov-io

This comment has been minimized.

codecov-io commented Dec 6, 2016

Current coverage is 73.31% (diff: 100%)

Merging #83 into MLIBZ-1481 will increase coverage by 0.05%

@@           MLIBZ-1481        #83   diff @@
============================================
  Files              67         67          
  Lines            6107       6108     +1   
  Methods           836        836          
  Messages            0          0          
  Branches          948        948          
============================================
+ Hits             4474       4478     +4   
+ Misses           1633       1630     -3   
  Partials            0          0          

Powered by Codecov. Last update 58ff1e5...9216ffd

@tejasranade tejasranade merged commit 9ae9319 into MLIBZ-1481 Dec 8, 2016

3 checks passed

codecov/patch 100% of diff hit (target 73.26%)
Details
codecov/project 73.31% (+0.05%) compared to 58ff1e5
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tejasranade tejasranade deleted the MLIBZ-1524 branch Dec 8, 2016

thomasconner added a commit that referenced this pull request Dec 15, 2016

Squashed commit of the following:
commit d72c581
Merge: ed53594 67691a7
Author: Thomas Conner <thomas@kinvey.com>
Date:   Thu Dec 15 16:53:10 2016 -0500

    Merge branch 'master' of github.com:Kinvey/js-sdk

    * 'master' of github.com:Kinvey/js-sdk:
      Fixes for sort, skip and limit on queries

commit 67691a7
Merge: 2ddca4b 4806f0f
Author: Thomas Conner <thomas.conner@me.com>
Date:   Thu Dec 15 16:52:34 2016 -0500

    Merge pull request #90 from Kinvey/MLIBZ-1557_query_bug

commit 4806f0f
Author: tejasranade <tejas.ranade@gmail.com>
Date:   Thu Dec 15 16:45:26 2016 -0500

    Fixes for sort, skip and limit on queries

commit ed53594
Author: Thomas Conner <thomas@kinvey.com>
Date:   Thu Dec 15 15:53:14 2016 -0500

    Remove pending unit tests.

commit 2ddca4b
Merge: 7f2620f ab2a79d
Author: Thomas Conner <thomas@kinvey.com>
Date:   Thu Dec 15 15:36:07 2016 -0500

    Merge branch 'master' of github.com:Kinvey/js-sdk

    * 'master' of github.com:Kinvey/js-sdk:
      bugfix for sync() not persisting pulled entities

commit 7f2620f
Author: Thomas Conner <thomas@kinvey.com>
Date:   Thu Dec 15 15:36:03 2016 -0500

    Remove unused PopupError

commit ab2a79d
Merge: 24935ff 50f98ea
Author: Thomas Conner <thomas.conner@me.com>
Date:   Wed Dec 14 15:49:57 2016 -0500

    Merge pull request #88 from Kinvey/MLIBZ-1553_sync_bug

commit 50f98ea
Author: tejasranade <tejas.ranade@gmail.com>
Date:   Wed Dec 14 11:16:32 2016 -0500

    bugfix for sync() not persisting pulled entities

commit 24935ff
Merge: cb3540b b6165e6
Author: Thomas Conner <thomas@kinvey.com>
Date:   Tue Dec 13 16:01:10 2016 -0500

    Merge branch 'MLIBZ-1481'

    * MLIBZ-1481:
      MLIBZ-1481 Fix typo in acl unit tests
      MLIBZ-1481 Revert changes made to Identities
      Revert "Remove unsuported identities"
      MLIBZ-1524 Use setter for query skip and limit properties
      Revert MLIBZ-1524 to allow fix to be made on separate branch
      Removed unused import in delta fetch test
      MLIBZ-1481 Add unit tests for delta fetch
      Update rxjs package to latest release candidate
      MLIBZ-1481 Add unit tests for entity acl
      MLIBZ-1481 Use lodash cloneDeep to clone an entities kmd attribute
      MLIBZ-1481 Add unit tests for entity metadata
      Add unit test for Mobile Identity Connect
      Add unit tests for Mobile Identity Connect
      Fix failing unit tests
      Remove unsuported identities
      Alias imports in tests
      Remove test/browser directory
      Remove test2 folder

commit b6165e6
Merge: 3752963 cb3540b
Author: Thomas Conner <thomas@kinvey.com>
Date:   Tue Dec 13 16:00:50 2016 -0500

    Merge branch 'master' into MLIBZ-1481

    * master:
      MLIBZ-1472 Test that a request timesout using default timeout
      MLIBZ-1532 Remove instanceof check
      Fixing failing unit test
      MLIBZ-1472 Check if client default timeout is correct
      MLIBZ-1472 Add test for checking default timeout on a request
      MLIBZ-1472 Add default timeout to client class
      Update README
      Update the github issue template

    # Conflicts:
    #	test/unit/request/network.test.js

commit cb3540b
Merge: 715b3cb b91a5ef
Author: Thomas Conner <thomas.conner@me.com>
Date:   Tue Dec 13 15:58:48 2016 -0500

    Merge pull request #85 from Kinvey/MLIBZ-1472

commit 3752963
Author: Thomas Conner <thomas@kinvey.com>
Date:   Tue Dec 13 11:38:00 2016 -0500

    MLIBZ-1481 Fix typo in acl unit tests

commit 0eedaaf
Author: Thomas Conner <thomas@kinvey.com>
Date:   Tue Dec 13 11:32:43 2016 -0500

    MLIBZ-1481 Revert changes made to Identities

commit db503a2
Author: Thomas Conner <thomas@kinvey.com>
Date:   Tue Dec 13 11:24:10 2016 -0500

    Revert "Remove unsuported identities"

    This reverts commit 0861828.

    # Conflicts:
    #	src/identity/index.js
    #	src/identity/src/identity.js

commit b91a5ef
Author: Thomas Conner <thomas@kinvey.com>
Date:   Tue Dec 13 10:49:26 2016 -0500

    MLIBZ-1472 Test that a request timesout using default timeout

commit 715b3cb
Merge: 4dd5e04 6aebb10
Author: Thomas Conner <thomas.conner@me.com>
Date:   Tue Dec 13 10:10:08 2016 -0500

    Merge pull request #87 from Kinvey/MLIBZ-1532

commit 6aebb10
Author: Thomas Conner <thomas@kinvey.com>
Date:   Mon Dec 12 11:03:57 2016 -0500

    MLIBZ-1532 Remove instanceof check

commit 99403fd
Author: Thomas Conner <thomas@kinvey.com>
Date:   Mon Dec 12 10:58:13 2016 -0500

    Fixing failing unit test

commit b16355d
Author: Thomas Conner <thomas@kinvey.com>
Date:   Mon Dec 12 10:34:51 2016 -0500

    MLIBZ-1472 Check if client default timeout is correct

commit 3e71300
Author: Thomas Conner <thomas@kinvey.com>
Date:   Mon Dec 12 09:35:56 2016 -0500

    MLIBZ-1472 Add test for checking default timeout on a request

commit dfe0246
Author: Thomas Conner <thomas@kinvey.com>
Date:   Mon Dec 12 09:34:04 2016 -0500

    MLIBZ-1472 Add default timeout to client class

commit 9ae9319
Merge: 58ff1e5 9216ffd
Author: Tejas Ranade <tejas.ranade@gmail.com>
Date:   Thu Dec 8 11:04:02 2016 -0500

    Merge pull request #83 from Kinvey/MLIBZ-1524

    Fix bug that prevents using delta fetch with a query

commit 9216ffd
Author: Thomas Conner <thomas@kinvey.com>
Date:   Tue Dec 6 14:24:31 2016 -0500

    MLIBZ-1524 Use setter for query skip and limit properties

commit 58ff1e5
Author: Thomas Conner <thomas@kinvey.com>
Date:   Tue Dec 6 14:16:44 2016 -0500

    Revert MLIBZ-1524 to allow fix to be made on separate branch

commit dd335ed
Author: Thomas Conner <thomas@kinvey.com>
Date:   Tue Dec 6 11:47:28 2016 -0500

    Removed unused import in delta fetch test

commit 6d0d5a8
Author: Thomas Conner <thomas@kinvey.com>
Date:   Tue Dec 6 11:46:58 2016 -0500

    MLIBZ-1481 Add unit tests for delta fetch

commit 3862554
Author: Thomas Conner <thomas@kinvey.com>
Date:   Mon Dec 5 15:43:05 2016 -0500

    Update rxjs package to latest release candidate

commit 62009ae
Author: Thomas Conner <thomas@kinvey.com>
Date:   Mon Dec 5 15:18:42 2016 -0500

    MLIBZ-1481 Add unit tests for entity acl

commit e185d6c
Author: Thomas Conner <thomas@kinvey.com>
Date:   Mon Dec 5 14:21:26 2016 -0500

    MLIBZ-1481 Use lodash cloneDeep to clone an entities kmd attribute

commit c602899
Author: Thomas Conner <thomas@kinvey.com>
Date:   Mon Dec 5 14:19:01 2016 -0500

    MLIBZ-1481 Add unit tests for entity metadata

commit cbd8c28
Author: Thomas Conner <thomas@kinvey.com>
Date:   Mon Dec 5 12:39:22 2016 -0500

    Add unit test for Mobile Identity Connect

commit 3a73e41
Author: Thomas Conner <thomas@kinvey.com>
Date:   Mon Dec 5 12:33:22 2016 -0500

    Add unit tests for Mobile Identity Connect

commit 6bce309
Author: Thomas Conner <thomas@kinvey.com>
Date:   Mon Dec 5 11:05:56 2016 -0500

    Fix failing unit tests

    Remove export of SocialIdentity enum and add export of AuthorizationGrant enum.

commit 0861828
Author: Thomas Conner <thomas@kinvey.com>
Date:   Mon Dec 5 11:01:30 2016 -0500

    Remove unsuported identities

commit c0b1ddd
Author: Thomas Conner <thomas@kinvey.com>
Date:   Mon Dec 5 10:42:18 2016 -0500

    Alias imports in tests

commit c240942
Author: Thomas Conner <thomas@kinvey.com>
Date:   Mon Dec 5 09:43:37 2016 -0500

    Remove test/browser directory

commit 54d85d6
Author: Thomas Conner <thomas@kinvey.com>
Date:   Mon Dec 5 09:42:58 2016 -0500

    Remove test2 folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment