New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on Error Object #89

Merged
merged 6 commits into from Dec 15, 2016

Conversation

Projects
None yet
3 participants
@thomasconner
Contributor

thomasconner commented Dec 15, 2016

Description

This PR fixes many issues with Error objects. It sets the name property to the correct name of the error. It adds the X-Kinvey-Request-Id as a property on the error.

Changes

  • Set nameproperty to name of the error.
  • Add BaseError extended by all custom errors.
  • Add unit test to check if X-Kinvey-Request-Id is set properly for an error.
@codecov-io

This comment has been minimized.

codecov-io commented Dec 15, 2016

Current coverage is 64.98% (diff: 78.09%)

Merging #89 into master will decrease coverage by 6.63%

@@             master        #89   diff @@
==========================================
  Files            74         73     -1   
  Lines          6581       6545    -36   
  Methods         890        889     -1   
  Messages          0          0          
  Branches       1027       1029     +2   
==========================================
- Hits           4713       4253   -460   
- Misses         1868       2292   +424   
  Partials          0          0          

Powered by Codecov. Last update d72c581...2ab7780

@tejasranade

LGTM

@thomasconner thomasconner merged commit affaa7a into master Dec 15, 2016

0 of 2 checks passed

codeclimate 6 new issues (3 fixed)
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@thomasconner thomasconner deleted the MLIBZ-1507 branch Dec 15, 2016

@thomasconner thomasconner restored the MLIBZ-1507 branch Dec 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment