New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2046: cascade delete #229

Merged
merged 4 commits into from Sep 5, 2017

Conversation

Projects
None yet
3 participants
@heyzooi
Contributor

heyzooi commented Aug 22, 2017

Description

Implementing cascade delete since find() operations was ending up accumulating wasted objects in the database

Changes

  • During save() the cache implementation now performs deletes on nested objects

Tests

  • Making sure the nested objects are also being deleted

@heyzooi heyzooi self-assigned this Aug 22, 2017

@heyzooi heyzooi requested a review from tejasranade Aug 22, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 22, 2017

Codecov Report

Merging #229 into develop will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #229      +/-   ##
===========================================
+ Coverage    90.83%   90.97%   +0.14%     
===========================================
  Files           65       65              
  Lines         7680     7782     +102     
===========================================
+ Hits          6976     7080     +104     
+ Misses         704      702       -2
Flag Coverage Δ
#Mac 88.24% <100%> (+0.15%) ⬆️
#iOS 89.82% <100%> (+0.13%) ⬆️
Impacted Files Coverage Δ
Kinvey/Kinvey/ObjCRuntime.swift 100% <100%> (ø) ⬆️
Kinvey/Kinvey/Persistable.swift 83.27% <100%> (+1.49%) ⬆️
Kinvey/Kinvey/RealmCache.swift 88.82% <100%> (+2.04%) ⬆️
Kinvey/Kinvey/Realtime.swift 74.64% <0%> (-0.62%) ⬇️
Kinvey/Kinvey/Kinvey.swift 100% <0%> (+0.9%) ⬆️
Kinvey/Kinvey/Client.swift 92.61% <0%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99ef2ae...ceac816. Read the comment docs.

codecov-io commented Aug 22, 2017

Codecov Report

Merging #229 into develop will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #229      +/-   ##
===========================================
+ Coverage    90.83%   90.97%   +0.14%     
===========================================
  Files           65       65              
  Lines         7680     7782     +102     
===========================================
+ Hits          6976     7080     +104     
+ Misses         704      702       -2
Flag Coverage Δ
#Mac 88.24% <100%> (+0.15%) ⬆️
#iOS 89.82% <100%> (+0.13%) ⬆️
Impacted Files Coverage Δ
Kinvey/Kinvey/ObjCRuntime.swift 100% <100%> (ø) ⬆️
Kinvey/Kinvey/Persistable.swift 83.27% <100%> (+1.49%) ⬆️
Kinvey/Kinvey/RealmCache.swift 88.82% <100%> (+2.04%) ⬆️
Kinvey/Kinvey/Realtime.swift 74.64% <0%> (-0.62%) ⬇️
Kinvey/Kinvey/Kinvey.swift 100% <0%> (+0.9%) ⬆️
Kinvey/Kinvey/Client.swift 92.61% <0%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99ef2ae...ceac816. Read the comment docs.

heyzooi added some commits Aug 22, 2017

@heyzooi heyzooi merged commit d636354 into develop Sep 5, 2017

2 of 3 checks passed

codebeat 0 issues resolved and 7 introduced
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@heyzooi heyzooi deleted the feature/MLIBZ-2046-cascade_delete branch Sep 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment