New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2043: automatic pagination #231

Merged
merged 3 commits into from Sep 13, 2017

Conversation

Projects
None yet
5 participants
@heyzooi
Contributor

heyzooi commented Aug 24, 2017

Description

Automatic pagination (optional, disabled by default) when the result set size exceeds the limit defined by the backend

Changes

  • DataStore additional argument called autoPagination
  • FindOperation checks if additional requests has to be made to get the pagination done

Tests

  • Unit tests checking the autoPagination disabled / enabled and with / without cache

@heyzooi heyzooi self-assigned this Aug 24, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 25, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (develop@15a36af). Click here to learn what that means.
The diff coverage is 92.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #231   +/-   ##
==========================================
  Coverage           ?   90.95%           
==========================================
  Files              ?       65           
  Lines              ?     7957           
  Branches           ?        0           
==========================================
  Hits               ?     7237           
  Misses             ?      720           
  Partials           ?        0
Flag Coverage Δ
#Mac 88.28% <92.93%> (?)
#iOS 89.84% <92.93%> (?)
Impacted Files Coverage Δ
Kinvey/Kinvey/Error.swift 91.25% <100%> (ø)
Kinvey/Kinvey/Kinvey.swift 99.26% <100%> (ø)
Kinvey/Kinvey/DataStore.swift 98.96% <100%> (ø)
Kinvey/Kinvey/HttpResponse.swift 75% <100%> (ø)
Kinvey/Kinvey/PullOperation.swift 100% <100%> (ø)
Kinvey/Kinvey/Entity.swift 90.9% <33.33%> (ø)
Kinvey/Kinvey/FindOperation.swift 91.94% <91.37%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15a36af...0e8da6b. Read the comment docs.

codecov-io commented Aug 25, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (develop@15a36af). Click here to learn what that means.
The diff coverage is 92.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #231   +/-   ##
==========================================
  Coverage           ?   90.95%           
==========================================
  Files              ?       65           
  Lines              ?     7957           
  Branches           ?        0           
==========================================
  Hits               ?     7237           
  Misses             ?      720           
  Partials           ?        0
Flag Coverage Δ
#Mac 88.28% <92.93%> (?)
#iOS 89.84% <92.93%> (?)
Impacted Files Coverage Δ
Kinvey/Kinvey/Error.swift 91.25% <100%> (ø)
Kinvey/Kinvey/Kinvey.swift 99.26% <100%> (ø)
Kinvey/Kinvey/DataStore.swift 98.96% <100%> (ø)
Kinvey/Kinvey/HttpResponse.swift 75% <100%> (ø)
Kinvey/Kinvey/PullOperation.swift 100% <100%> (ø)
Kinvey/Kinvey/Entity.swift 90.9% <33.33%> (ø)
Kinvey/Kinvey/FindOperation.swift 91.94% <91.37%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15a36af...0e8da6b. Read the comment docs.

Show outdated Hide outdated Kinvey/Kinvey/FindOperation.swift Outdated
@heyzooi

This comment has been minimized.

Show comment
Hide comment
@heyzooi

heyzooi Sep 7, 2017

Contributor

@tejasranade it should now be good to merge

Contributor

heyzooi commented Sep 7, 2017

@tejasranade it should now be good to merge

@heyzooi

This comment has been minimized.

Show comment
Hide comment
@heyzooi

heyzooi Sep 12, 2017

Contributor

@vinaygahlawat I'm wondering if you could review this one

Contributor

heyzooi commented Sep 12, 2017

@vinaygahlawat I'm wondering if you could review this one

@vinaygahlawat

LGTM

@heyzooi heyzooi merged commit bc56832 into develop Sep 13, 2017

2 of 3 checks passed

codebeat 6 issues resolved and 34 introduced
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@heyzooi heyzooi deleted the feature/MLIBZ-2043-automatic_pagination branch Sep 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment