New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2040: Subclassing File #233

Merged
merged 1 commit into from Aug 31, 2017

Conversation

Projects
None yet
3 participants
@heyzooi
Contributor

heyzooi commented Aug 29, 2017

Description

Subclassing File was not possible because mapping() must be open and not just public

Changes

  • File.mapping() was not open

Tests

  • MyFile used in tests is now in its own file so we don't import internal methods from the library causing the unit test to failure catching this bug

@heyzooi heyzooi self-assigned this Aug 29, 2017

@heyzooi heyzooi requested a review from tejasranade Aug 29, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 29, 2017

Codecov Report

Merging #233 into develop will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #233      +/-   ##
==========================================
+ Coverage    90.76%   90.8%   +0.03%     
==========================================
  Files           65      65              
  Lines         7692    7692              
==========================================
+ Hits          6982    6985       +3     
+ Misses         710     707       -3
Flag Coverage Δ
#Mac 88.12% <100%> (+0.09%) ⬆️
#iOS 89.66% <100%> (+0.03%) ⬆️
Impacted Files Coverage Δ
Kinvey/Kinvey/File.swift 83.63% <100%> (ø) ⬆️
Kinvey/Kinvey/Kinvey.swift 100% <0%> (+0.9%) ⬆️
Kinvey/Kinvey/Client.swift 92.61% <0%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10c84a4...8cc7853. Read the comment docs.

codecov-io commented Aug 29, 2017

Codecov Report

Merging #233 into develop will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #233      +/-   ##
==========================================
+ Coverage    90.76%   90.8%   +0.03%     
==========================================
  Files           65      65              
  Lines         7692    7692              
==========================================
+ Hits          6982    6985       +3     
+ Misses         710     707       -3
Flag Coverage Δ
#Mac 88.12% <100%> (+0.09%) ⬆️
#iOS 89.66% <100%> (+0.03%) ⬆️
Impacted Files Coverage Δ
Kinvey/Kinvey/File.swift 83.63% <100%> (ø) ⬆️
Kinvey/Kinvey/Kinvey.swift 100% <0%> (+0.9%) ⬆️
Kinvey/Kinvey/Client.swift 92.61% <0%> (+0.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10c84a4...8cc7853. Read the comment docs.

@tejasranade

LGTM.
@heyzooi - do we have a documentation snippet showing how / why to subclass a file? If not, please add one.

@heyzooi

This comment has been minimized.

Show comment
Hide comment
@heyzooi

heyzooi Aug 31, 2017

Contributor

@tejasranade yes, it's coming! @AntonDobrev is just waiting for us to make the release so he can change our DevCenter as well

Contributor

heyzooi commented Aug 31, 2017

@tejasranade yes, it's coming! @AntonDobrev is just waiting for us to make the release so he can change our DevCenter as well

@heyzooi heyzooi merged commit b11f3f9 into develop Aug 31, 2017

3 checks passed

codebeat Target branch is not tracked
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@heyzooi heyzooi deleted the feature/MLIBZ-2040-subclass_file branch Aug 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment