New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2051: LiveService ACL unit tests #235

Merged
merged 1 commit into from Sep 5, 2017

Conversation

Projects
None yet
3 participants
@heyzooi
Contributor

heyzooi commented Aug 30, 2017

Description

LiveService ACL unit tests were missing

Changes

  • debug added to Error.unauthorized

Tests

  • New unit tests added to test ACL for publishers and subscribers

@heyzooi heyzooi self-assigned this Aug 30, 2017

@heyzooi heyzooi requested a review from tejasranade Aug 30, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 31, 2017

Codecov Report

Merging #235 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #235      +/-   ##
===========================================
+ Coverage    90.76%   90.78%   +0.01%     
===========================================
  Files           65       65              
  Lines         7692     7674      -18     
===========================================
- Hits          6982     6967      -15     
+ Misses         710      707       -3
Flag Coverage Δ
#Mac 88.04% <100%> (+0.01%) ⬆️
#iOS 89.64% <100%> (+0.01%) ⬆️
Impacted Files Coverage Δ
Kinvey/Kinvey/PushOperation.swift 89% <100%> (+0.22%) ⬆️
Kinvey/Kinvey/MIC.swift 95.56% <100%> (ø) ⬆️
Kinvey/Kinvey/Error.swift 91.02% <100%> (-1.98%) ⬇️
Kinvey/Kinvey/Kinvey.swift 99.1% <100%> (+0.01%) ⬆️
Kinvey/Kinvey/Realtime.swift 74.62% <0%> (+1.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43955c9...7604c0a. Read the comment docs.

codecov-io commented Aug 31, 2017

Codecov Report

Merging #235 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #235      +/-   ##
===========================================
+ Coverage    90.76%   90.78%   +0.01%     
===========================================
  Files           65       65              
  Lines         7692     7674      -18     
===========================================
- Hits          6982     6967      -15     
+ Misses         710      707       -3
Flag Coverage Δ
#Mac 88.04% <100%> (+0.01%) ⬆️
#iOS 89.64% <100%> (+0.01%) ⬆️
Impacted Files Coverage Δ
Kinvey/Kinvey/PushOperation.swift 89% <100%> (+0.22%) ⬆️
Kinvey/Kinvey/MIC.swift 95.56% <100%> (ø) ⬆️
Kinvey/Kinvey/Error.swift 91.02% <100%> (-1.98%) ⬇️
Kinvey/Kinvey/Kinvey.swift 99.1% <100%> (+0.01%) ⬆️
Kinvey/Kinvey/Realtime.swift 74.62% <0%> (+1.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43955c9...7604c0a. Read the comment docs.

@heyzooi heyzooi merged commit 17cd2c5 into develop Sep 5, 2017

3 checks passed

codebeat 4 issues resolved and 0 introduced
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@heyzooi heyzooi deleted the feature/MLIBZ-2051-liveservice_acl_unit_tests branch Sep 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment