New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2058: fixing the cache path when running on macOS #236

Merged
merged 2 commits into from Sep 12, 2017

Conversation

Projects
None yet
2 participants
@heyzooi
Contributor

heyzooi commented Aug 30, 2017

Description

Cache path on macOS was ~/Documents/<kid>, but should be ~/Library/Application Support/<bundle id>/<kid>

Changes

  • Kinvey.swift now contains a internal cacheBasePath and the rest of the code should use it

Tests

  • Unit test that check if the cache is being saved in the right path

@heyzooi heyzooi self-assigned this Aug 30, 2017

@heyzooi heyzooi requested a review from tejasranade Aug 30, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Aug 31, 2017

Codecov Report

Merging #236 into develop will increase coverage by 0.39%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #236      +/-   ##
===========================================
+ Coverage    90.93%   91.33%   +0.39%     
===========================================
  Files           65       65              
  Lines         7756     8053     +297     
===========================================
+ Hits          7053     7355     +302     
+ Misses         703      698       -5
Flag Coverage Δ
#Mac 88.65% <91.66%> (+0.42%) ⬆️
#iOS 90.25% <91.66%> (+0.45%) ⬆️
Impacted Files Coverage Δ
Kinvey/Kinvey/Kinvey.swift 99.15% <ø> (+0.04%) ⬆️
Kinvey/Kinvey/FileStore.swift 82.94% <100%> (ø) ⬆️
Kinvey/Kinvey/Cache.swift 90% <100%> (+0.2%) ⬆️
Kinvey/Kinvey/Client.swift 91.58% <100%> (-0.05%) ⬇️
Kinvey/Kinvey/CacheManager.swift 94.44% <90%> (ø) ⬆️
Kinvey/Kinvey/GetOperation.swift 100% <0%> (ø) ⬆️
Kinvey/Kinvey/RequestFactory.swift 100% <0%> (ø) ⬆️
Kinvey/Kinvey/HttpRequestFactory.swift 99.82% <0%> (+0.26%) ⬆️
Kinvey/Kinvey/User.swift 97.39% <0%> (+0.42%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d636354...49ab78b. Read the comment docs.

codecov-io commented Aug 31, 2017

Codecov Report

Merging #236 into develop will increase coverage by 0.39%.
The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #236      +/-   ##
===========================================
+ Coverage    90.93%   91.33%   +0.39%     
===========================================
  Files           65       65              
  Lines         7756     8053     +297     
===========================================
+ Hits          7053     7355     +302     
+ Misses         703      698       -5
Flag Coverage Δ
#Mac 88.65% <91.66%> (+0.42%) ⬆️
#iOS 90.25% <91.66%> (+0.45%) ⬆️
Impacted Files Coverage Δ
Kinvey/Kinvey/Kinvey.swift 99.15% <ø> (+0.04%) ⬆️
Kinvey/Kinvey/FileStore.swift 82.94% <100%> (ø) ⬆️
Kinvey/Kinvey/Cache.swift 90% <100%> (+0.2%) ⬆️
Kinvey/Kinvey/Client.swift 91.58% <100%> (-0.05%) ⬇️
Kinvey/Kinvey/CacheManager.swift 94.44% <90%> (ø) ⬆️
Kinvey/Kinvey/GetOperation.swift 100% <0%> (ø) ⬆️
Kinvey/Kinvey/RequestFactory.swift 100% <0%> (ø) ⬆️
Kinvey/Kinvey/HttpRequestFactory.swift 99.82% <0%> (+0.26%) ⬆️
Kinvey/Kinvey/User.swift 97.39% <0%> (+0.42%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d636354...49ab78b. Read the comment docs.

heyzooi added some commits Aug 30, 2017

@heyzooi heyzooi merged commit 160c857 into develop Sep 12, 2017

3 checks passed

codebeat 15 issues resolved and 11 introduced
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@heyzooi heyzooi deleted the feature/MLIBZ-2058-cache_path_on_macos branch Sep 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment