New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed separator for micID from : to . #238

Merged
merged 43 commits into from Sep 8, 2017

Conversation

Projects
None yet
4 participants
@tejasranade
Member

tejasranade commented Sep 6, 2017

Description

In response to a change in the backend, the micId separator is now a . character instead of :.

Changes

Tests

Changed existing tests

heyzooi and others added some commits Sep 12, 2016

Revert "Include 3rd party frameworks"
This reverts commit 2683d05 [formerly 765c4df].


Former-commit-id: e51a271
Merge branch 'release/3.3.4'
# Conflicts:
#	.gitignore


Former-commit-id: b5d4f28
Merge branch 'develop'
Former-commit-id: 422a9a7
Merge branch 'develop'
Former-commit-id: f9d8d55
spring cleaning
Former-commit-id: 90d2249

@tejasranade tejasranade requested a review from heyzooi Sep 6, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Sep 6, 2017

Codecov Report

Merging #238 into develop will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #238     +/-   ##
==========================================
+ Coverage    90.93%   91.03%   +0.1%     
==========================================
  Files           65       65             
  Lines         7756     7833     +77     
==========================================
+ Hits          7053     7131     +78     
+ Misses         703      702      -1
Flag Coverage Δ
#Mac 88.45% <80%> (+0.21%) ⬆️
#iOS 89.91% <100%> (+0.11%) ⬆️
Impacted Files Coverage Δ
Kinvey/Kinvey/HttpRequest.swift 81.48% <100%> (ø) ⬆️
Kinvey/Kinvey/RequestFactory.swift 100% <100%> (ø) ⬆️
Kinvey/Kinvey/MIC.swift 95.56% <100%> (ø) ⬆️
Kinvey/Kinvey/User.swift 96.97% <100%> (ø) ⬆️
Kinvey/Kinvey/Endpoint.swift 96.92% <100%> (ø) ⬆️
Kinvey/Kinvey/HttpRequestFactory.swift 99.56% <100%> (ø) ⬆️
Kinvey/Kinvey/Error.swift 91.66% <0%> (+0.64%) ⬆️
Kinvey/Kinvey/PushOperation.swift 89.71% <0%> (+0.71%) ⬆️
Kinvey/Kinvey/RealmCache.swift 89.58% <0%> (+0.75%) ⬆️
Kinvey/Kinvey/Kinvey.swift 100% <0%> (+0.89%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d636354...7a7cd15. Read the comment docs.

codecov-io commented Sep 6, 2017

Codecov Report

Merging #238 into develop will increase coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #238     +/-   ##
==========================================
+ Coverage    90.93%   91.03%   +0.1%     
==========================================
  Files           65       65             
  Lines         7756     7833     +77     
==========================================
+ Hits          7053     7131     +78     
+ Misses         703      702      -1
Flag Coverage Δ
#Mac 88.45% <80%> (+0.21%) ⬆️
#iOS 89.91% <100%> (+0.11%) ⬆️
Impacted Files Coverage Δ
Kinvey/Kinvey/HttpRequest.swift 81.48% <100%> (ø) ⬆️
Kinvey/Kinvey/RequestFactory.swift 100% <100%> (ø) ⬆️
Kinvey/Kinvey/MIC.swift 95.56% <100%> (ø) ⬆️
Kinvey/Kinvey/User.swift 96.97% <100%> (ø) ⬆️
Kinvey/Kinvey/Endpoint.swift 96.92% <100%> (ø) ⬆️
Kinvey/Kinvey/HttpRequestFactory.swift 99.56% <100%> (ø) ⬆️
Kinvey/Kinvey/Error.swift 91.66% <0%> (+0.64%) ⬆️
Kinvey/Kinvey/PushOperation.swift 89.71% <0%> (+0.71%) ⬆️
Kinvey/Kinvey/RealmCache.swift 89.58% <0%> (+0.75%) ⬆️
Kinvey/Kinvey/Kinvey.swift 100% <0%> (+0.89%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d636354...7a7cd15. Read the comment docs.

@heyzooi

it needs to be rebase against develop, not master. We still using git flow for this repo. Otherwise, looks good to merge.

@heyzooi heyzooi changed the base branch from master to develop Sep 6, 2017

@heyzooi

heyzooi approved these changes Sep 7, 2017

@heyzooi heyzooi merged commit 2ba5e0c into develop Sep 8, 2017

3 checks passed

codebeat 17 issues resolved and 14 introduced
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@heyzooi heyzooi deleted the MLIBZ-2029_micId_separator branch Sep 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment