New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-519: bug fix for resumable uploads #239

Merged
merged 1 commit into from Sep 25, 2017

Conversation

Projects
None yet
2 participants
@heyzooi
Contributor

heyzooi commented Sep 19, 2017

Description

Bug fix for resumable uploads

Changes

  • Create new methods call create() to allow create the bucket and keep the fileId and _uploadURL so we can resume the upload

  • In case of 308 responses but there's no Range header it means the bucket still empty, so just send the file from the beginning

Tests

  • No need for additional tests

@heyzooi heyzooi self-assigned this Sep 19, 2017

@heyzooi heyzooi requested review from tejasranade and vinaygahlawat Sep 19, 2017

@vinaygahlawat

LGTM

@heyzooi heyzooi merged commit 38ab84e into develop Sep 25, 2017

2 of 3 checks passed

codebeat 2 issues resolved and 7 introduced
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@heyzooi heyzooi deleted the feature/MLIBZ-519-resume_upload branch Sep 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment