New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-1921: Swift 4 #245

Merged
merged 6 commits into from Sep 28, 2017

Conversation

Projects
None yet
2 participants
@heyzooi
Contributor

heyzooi commented Sep 28, 2017

Changes for Swift 4

@heyzooi heyzooi requested a review from tejasranade Sep 28, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Sep 28, 2017

Codecov Report

Merging #245 into develop will decrease coverage by 3.2%.
The diff coverage is 82.52%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #245      +/-   ##
===========================================
- Coverage     90.9%   87.69%   -3.21%     
===========================================
  Files           65       65              
  Lines         7924     7434     -490     
===========================================
- Hits          7203     6519     -684     
- Misses         721      915     +194
Flag Coverage Δ
#Mac 87.69% <82.52%> (-0.47%) ⬇️
#iOS ?
Impacted Files Coverage Δ
Kinvey/Kinvey/Entity.swift 88.88% <ø> (-2.03%) ⬇️
Kinvey/Kinvey/MIC.swift 90.29% <ø> (-5.27%) ⬇️
Kinvey/Kinvey/Acl.swift 96.55% <ø> (ø) ⬆️
Kinvey/Kinvey/Metadata.swift 91.48% <ø> (ø) ⬆️
Kinvey/Kinvey/Geolocation.swift 100% <ø> (ø) ⬆️
Kinvey/Kinvey/File.swift 83.63% <ø> (ø) ⬆️
Kinvey/Kinvey/RealmCache.swift 89.25% <ø> (+0.42%) ⬆️
Kinvey/Kinvey/Kinvey.swift 93.79% <ø> (-5.43%) ⬇️
Kinvey/Kinvey/Push.swift 4.16% <0%> (-63.88%) ⬇️
Kinvey/Kinvey/Persistable.swift 80.98% <0%> (-2.3%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3d029d...e584dc7. Read the comment docs.

codecov-io commented Sep 28, 2017

Codecov Report

Merging #245 into develop will decrease coverage by 3.2%.
The diff coverage is 82.52%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #245      +/-   ##
===========================================
- Coverage     90.9%   87.69%   -3.21%     
===========================================
  Files           65       65              
  Lines         7924     7434     -490     
===========================================
- Hits          7203     6519     -684     
- Misses         721      915     +194
Flag Coverage Δ
#Mac 87.69% <82.52%> (-0.47%) ⬇️
#iOS ?
Impacted Files Coverage Δ
Kinvey/Kinvey/Entity.swift 88.88% <ø> (-2.03%) ⬇️
Kinvey/Kinvey/MIC.swift 90.29% <ø> (-5.27%) ⬇️
Kinvey/Kinvey/Acl.swift 96.55% <ø> (ø) ⬆️
Kinvey/Kinvey/Metadata.swift 91.48% <ø> (ø) ⬆️
Kinvey/Kinvey/Geolocation.swift 100% <ø> (ø) ⬆️
Kinvey/Kinvey/File.swift 83.63% <ø> (ø) ⬆️
Kinvey/Kinvey/RealmCache.swift 89.25% <ø> (+0.42%) ⬆️
Kinvey/Kinvey/Kinvey.swift 93.79% <ø> (-5.43%) ⬇️
Kinvey/Kinvey/Push.swift 4.16% <0%> (-63.88%) ⬇️
Kinvey/Kinvey/Persistable.swift 80.98% <0%> (-2.3%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3d029d...e584dc7. Read the comment docs.

@heyzooi heyzooi self-assigned this Sep 28, 2017

@heyzooi heyzooi merged commit c5c23df into develop Sep 28, 2017

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
codebeat Target branch is not tracked
Details

@heyzooi heyzooi deleted the feature/MLIBZ-1921-swift4-xcode9 branch Sep 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment