New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2106: Support for SFAuthenticationSession (new iOS 11 feature) #246

Merged
merged 3 commits into from Oct 2, 2017

Conversation

Projects
None yet
3 participants
@heyzooi
Contributor

heyzooi commented Sep 28, 2017

Description

Support for SFAuthenticationSession (new iOS 11 feature)

Changes

  • Adding new case for MICUserInterface called safariAuthenticationSession

Tests

  • Added option to the test app

@heyzooi heyzooi self-assigned this Sep 28, 2017

@heyzooi heyzooi requested a review from tejasranade Sep 28, 2017

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Sep 29, 2017

Codecov Report

Merging #246 into develop will decrease coverage by 0.41%.
The diff coverage is 20%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #246      +/-   ##
===========================================
- Coverage    90.37%   89.96%   -0.42%     
===========================================
  Files           65       65              
  Lines         7976     8018      +42     
===========================================
+ Hits          7208     7213       +5     
- Misses         768      805      +37
Flag Coverage Δ
#Mac 87.69% <0%> (-0.01%) ⬇️
#iOS 88.86% <20%> (-0.41%) ⬇️
Impacted Files Coverage Δ
Kinvey/Kinvey/MIC.swift 95.54% <100%> (-0.02%) ⬇️
Kinvey/Kinvey/User.swift 92.49% <18.36%> (-4.54%) ⬇️
Kinvey/Kinvey/Kinvey.swift 100% <0%> (+0.77%) ⬆️
Kinvey/Kinvey/Client.swift 92.57% <0%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f12f4bf...96a8cff. Read the comment docs.

codecov-io commented Sep 29, 2017

Codecov Report

Merging #246 into develop will decrease coverage by 0.41%.
The diff coverage is 20%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #246      +/-   ##
===========================================
- Coverage    90.37%   89.96%   -0.42%     
===========================================
  Files           65       65              
  Lines         7976     8018      +42     
===========================================
+ Hits          7208     7213       +5     
- Misses         768      805      +37
Flag Coverage Δ
#Mac 87.69% <0%> (-0.01%) ⬇️
#iOS 88.86% <20%> (-0.41%) ⬇️
Impacted Files Coverage Δ
Kinvey/Kinvey/MIC.swift 95.54% <100%> (-0.02%) ⬇️
Kinvey/Kinvey/User.swift 92.49% <18.36%> (-4.54%) ⬇️
Kinvey/Kinvey/Kinvey.swift 100% <0%> (+0.77%) ⬆️
Kinvey/Kinvey/Client.swift 92.57% <0%> (+0.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f12f4bf...96a8cff. Read the comment docs.

@heyzooi heyzooi merged commit 8249d81 into develop Oct 2, 2017

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
codebeat 22 issues resolved and 21 introduced
Details

@heyzooi heyzooi deleted the feature/MLIBZ-2106-support_for_sfauthenticationsession branch Oct 2, 2017

heyzooi added a commit that referenced this pull request Oct 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment