New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2102: bugfix for sync since it was not filtering by collection #247

Merged
merged 1 commit into from Oct 3, 2017

Conversation

Projects
None yet
3 participants
@heyzooi
Contributor

heyzooi commented Oct 2, 2017

Description

Bugfix for sync since it was not filtering by collection

Changes

  • Filtering pending operations by collection at RealmSync

Tests

  • Checking if the syncCount() and the result of a sync() calls results in the expected number of entities being pushed

@heyzooi heyzooi self-assigned this Oct 2, 2017

@heyzooi heyzooi requested a review from tejasranade Oct 2, 2017

@tejasranade

@heyzooi the change looks good.
The only comment is to check that all our tests account for this nuance.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 2, 2017

Codecov Report

Merging #247 into develop will increase coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #247      +/-   ##
===========================================
+ Coverage    90.37%   90.63%   +0.26%     
===========================================
  Files           65       65              
  Lines         7976     8287     +311     
===========================================
+ Hits          7208     7511     +303     
- Misses         768      776       +8
Flag Coverage Δ
#Mac 88.17% <100%> (+0.47%) ⬆️
#iOS 89.57% <100%> (+0.3%) ⬆️
Impacted Files Coverage Δ
Kinvey/Kinvey/RealmSync.swift 100% <100%> (ø) ⬆️
Kinvey/Kinvey/User.swift 94.77% <0%> (-2.26%) ⬇️
Kinvey/Kinvey/RequestFactory.swift 100% <0%> (ø) ⬆️
Kinvey/Kinvey/MIC.swift 96.3% <0%> (+0.74%) ⬆️
Kinvey/Kinvey/URLSessionTaskRequest.swift 91.2% <0%> (+1.65%) ⬆️
Kinvey/Kinvey/FileStore.swift 84.1% <0%> (+5.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f12f4bf...e472dcc. Read the comment docs.

codecov-io commented Oct 2, 2017

Codecov Report

Merging #247 into develop will increase coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #247      +/-   ##
===========================================
+ Coverage    90.37%   90.63%   +0.26%     
===========================================
  Files           65       65              
  Lines         7976     8287     +311     
===========================================
+ Hits          7208     7511     +303     
- Misses         768      776       +8
Flag Coverage Δ
#Mac 88.17% <100%> (+0.47%) ⬆️
#iOS 89.57% <100%> (+0.3%) ⬆️
Impacted Files Coverage Δ
Kinvey/Kinvey/RealmSync.swift 100% <100%> (ø) ⬆️
Kinvey/Kinvey/User.swift 94.77% <0%> (-2.26%) ⬇️
Kinvey/Kinvey/RequestFactory.swift 100% <0%> (ø) ⬆️
Kinvey/Kinvey/MIC.swift 96.3% <0%> (+0.74%) ⬆️
Kinvey/Kinvey/URLSessionTaskRequest.swift 91.2% <0%> (+1.65%) ⬆️
Kinvey/Kinvey/FileStore.swift 84.1% <0%> (+5.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f12f4bf...e472dcc. Read the comment docs.

@heyzooi heyzooi merged commit ddd5cc2 into develop Oct 3, 2017

3 checks passed

codebeat no reportable quality changes
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@heyzooi heyzooi deleted the feature/MLIBZ-2102-sync_bugfix branch Oct 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment