New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2111: bugfix transforms were being ignored when saving object using dynamic Realm #250

Merged
merged 2 commits into from Oct 18, 2017

Conversation

Projects
None yet
3 participants
@heyzooi
Contributor

heyzooi commented Oct 18, 2017

Description

MLIBZ-2111: bugfix transforms were being ignored when saving object using dynamic Realm

Changes

  • RealmCache.save() using dynamic Realm was not considering cases where a transform needs to be applied

Tests

  • New unit test added to test a scenario where a Date, which requires some transformation to JSON, is being saved to Realm

@heyzooi heyzooi self-assigned this Oct 18, 2017

@heyzooi heyzooi requested a review from tejasranade Oct 18, 2017

@@ -186,6 +186,60 @@ class DataTypeTestCase: StoreTestCase {
}
func testDatePull() {

This comment has been minimized.

@tejasranade

tejasranade Oct 18, 2017

Member

I think instead of a test like testDatePull(), you should write a test that does basic operations on all our supported datatypes. This can go in a future PR.

@tejasranade

tejasranade Oct 18, 2017

Member

I think instead of a test like testDatePull(), you should write a test that does basic operations on all our supported datatypes. This can go in a future PR.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 18, 2017

Codecov Report

Merging #250 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
+ Coverage   87.69%   87.69%   +<.01%     
==========================================
  Files          65       65              
  Lines        7443     7445       +2     
==========================================
+ Hits         6527     6529       +2     
  Misses        916      916
Flag Coverage Δ
#Mac 87.69% <100%> (ø) ⬆️
Impacted Files Coverage Δ
Kinvey/Kinvey/RealmCache.swift 89.29% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83680fe...ce2f313. Read the comment docs.

codecov-io commented Oct 18, 2017

Codecov Report

Merging #250 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
+ Coverage   87.69%   87.69%   +<.01%     
==========================================
  Files          65       65              
  Lines        7443     7445       +2     
==========================================
+ Hits         6527     6529       +2     
  Misses        916      916
Flag Coverage Δ
#Mac 87.69% <100%> (ø) ⬆️
Impacted Files Coverage Δ
Kinvey/Kinvey/RealmCache.swift 89.29% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83680fe...ce2f313. Read the comment docs.

@heyzooi heyzooi merged commit 6b8da8b into master Oct 18, 2017

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
codebeat no reportable quality changes
Details
codeclimate All good!
Details

@heyzooi heyzooi deleted the feature/MLIBZ-2111-bugfix_date_transform branch Oct 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment