viewer: channels not ordered correctly #13

Closed
Kissaki opened this Issue Sep 12, 2010 · 2 comments

1 participant

@Kissaki
Owner

the viewer will not consistently order channels

@Kissaki
Owner

It was reported/talked about that this is an Ice 3.4 issue (and thus not MumPI).
To be verified.
(the Ice structure not returning in a specific order)

@Kissaki
Owner

Actually, I just noticed #26 was a pull request that (should have) fixed it.

It still just works on my debian, with php-zeroc-ice 3.3.
Maybe it’s an issue specific to 3.4?

@Kissaki Kissaki modified the milestone: 2.2.5, 2.2.6 Aug 25, 2014
@Kissaki Kissaki added a commit that closed this issue Dec 9, 2015
@Kissaki Order channels by position and name, order users by name [viewer2]
Fixes #13 viewer: channels not ordered correctly

Using one function for object name comparison for two types of objects
(channels and users) is a bit hacky and error prone.

Use the Intl.Collator where available (IE >= 11), or the string
localeCompare otherwise. This should improve performance where available.
2aed62f
@Kissaki Kissaki closed this in 2aed62f Dec 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment