From f778ae425e5de96c7f20109dc036b9203cb19bf5 Mon Sep 17 00:00:00 2001 From: Tim Carr Date: Thu, 9 Oct 2025 17:28:32 +0800 Subject: [PATCH 1/2] Remove redundant tests --- tests/ConvertKitAPIKeyTest.php | 358 --------------------------------- 1 file changed, 358 deletions(-) diff --git a/tests/ConvertKitAPIKeyTest.php b/tests/ConvertKitAPIKeyTest.php index d6f0b0c..16732f3 100644 --- a/tests/ConvertKitAPIKeyTest.php +++ b/tests/ConvertKitAPIKeyTest.php @@ -246,42 +246,6 @@ public function testCreateTags() ]); } - /** - * Test that create_tags() throws a ClientException when attempting - * to create blank tags, as this is only supported using OAuth. - * - * @since 2.2.0 - * - * @return void - */ - public function testCreateTagsBlank() - { - $this->expectException(ClientException::class); - $result = $this->api->create_tags([ - '', - '', - ]); - } - - /** - * Test that create_tags() throws a ClientException when creating - * tags that already exists, as this is only supported using OAuth. - * - * @since 2.2.0 - * - * @return void - */ - public function testCreateTagsThatExist() - { - $this->expectException(ClientException::class); - $result = $this->api->create_tags( - [ - $_ENV['CONVERTKIT_API_TAG_NAME'], - $_ENV['CONVERTKIT_API_TAG_NAME_2'], - ] - ); - } - /** * Test that add_subscribers_to_forms() throws a ClientException when * attempting to add subscribers to forms, as this is only supported @@ -319,167 +283,6 @@ public function testAddSubscribersToForms() ); } - /** - * Test that add_subscribers_to_forms() returns a ClientException - * when a referrer URL is specified, as this is only supported - * using OAuth. - * - * @since 2.2.0 - * - * @return void - */ - public function testAddSubscribersToFormsWithReferrer() - { - // Create subscriber. - $emailAddress = $this->generateEmailAddress(); - $subscriber = $this->api->create_subscriber( - email_address: $emailAddress - ); - - // Set subscriber_id to ensure subscriber is unsubscribed after test. - $this->subscriber_ids[] = $subscriber->subscriber->id; - - $this->expectException(ClientException::class); - - // Add subscribers to forms. - $result = $this->api->add_subscribers_to_forms( - forms_subscribers_ids: [ - [ - 'form_id' => (int) $_ENV['CONVERTKIT_API_FORM_ID'], - 'subscriber_id' => $subscriber->subscriber->id, - 'referrer' => 'https://mywebsite.com/bfpromo/', - ], - [ - 'form_id' => (int) $_ENV['CONVERTKIT_API_FORM_ID_2'], - 'subscriber_id' => $subscriber->subscriber->id, - 'referrer' => 'https://mywebsite.com/bfpromo/', - ], - ] - ); - } - - /** - * Test that add_subscribers_to_forms() returns a ClientException - * when a referrer URL with UTM parameters is specified, as this is only - * supported using OAuth. - * - * @since 2.2.0 - * - * @return void - */ - public function testAddSubscribersToFormsWithReferrerUTMParams() - { - // Define referrer. - $referrerUTMParams = [ - 'utm_source' => 'facebook', - 'utm_medium' => 'cpc', - 'utm_campaign' => 'black_friday', - 'utm_term' => 'car_owners', - 'utm_content' => 'get_10_off', - ]; - $referrer = 'https://mywebsite.com/bfpromo/?' . http_build_query($referrerUTMParams); - - // Create subscriber. - $emailAddress = $this->generateEmailAddress(); - $subscriber = $this->api->create_subscriber( - email_address: $emailAddress - ); - - // Set subscriber_id to ensure subscriber is unsubscribed after test. - $this->subscriber_ids[] = $subscriber->subscriber->id; - - $this->expectException(ClientException::class); - - // Add subscribers to forms. - $result = $this->api->add_subscribers_to_forms( - forms_subscribers_ids: [ - [ - 'form_id' => (int) $_ENV['CONVERTKIT_API_FORM_ID'], - 'subscriber_id' => $subscriber->subscriber->id, - 'referrer' => $referrer, - ], - [ - 'form_id' => (int) $_ENV['CONVERTKIT_API_FORM_ID_2'], - 'subscriber_id' => $subscriber->subscriber->id, - 'referrer' => $referrer, - ], - ] - ); - } - - /** - * Test that add_subscribers_to_forms() returns a ClientException - * when invalid Form IDs are specified, as this is only supported - * using OAuth. - * - * @since 2.2.0 - * - * @return void - */ - public function testAddSubscribersToFormsWithInvalidFormIDs() - { - // Create subscriber. - $emailAddress = $this->generateEmailAddress(); - $subscriber = $this->api->create_subscriber( - email_address: $emailAddress - ); - - // Set subscriber_id to ensure subscriber is unsubscribed after test. - $this->subscriber_ids[] = $subscriber->subscriber->id; - - $this->expectException(ClientException::class); - - // Add subscribers to forms. - $result = $this->api->add_subscribers_to_forms( - forms_subscribers_ids: [ - [ - 'form_id' => 9999999, - 'subscriber_id' => $subscriber->subscriber->id, - ], - [ - 'form_id' => 9999999, - 'subscriber_id' => $subscriber->subscriber->id, - ], - ] - ); - } - - /** - * Test that add_subscribers_to_forms() returns a ClientException - * when invalid Subscriber IDs are specified, as this is only supported - * - * @since 2.2.0 - * - * @return void - */ - public function testAddSubscribersToFormsWithInvalidSubscriberIDs() - { - // Create subscriber. - $emailAddress = $this->generateEmailAddress(); - $subscriber = $this->api->create_subscriber( - email_address: $emailAddress - ); - - // Set subscriber_id to ensure subscriber is unsubscribed after test. - $this->subscriber_ids[] = $subscriber->subscriber->id; - - $this->expectException(ClientException::class); - - // Add subscribers to forms. - $result = $this->api->add_subscribers_to_forms( - forms_subscribers_ids: [ - [ - 'form_id' => (int) $_ENV['CONVERTKIT_API_FORM_ID'], - 'subscriber_id' => 999999, - ], - [ - 'form_id' => (int) $_ENV['CONVERTKIT_API_FORM_ID_2'], - 'subscriber_id' => 999999, - ], - ] - ); - } - /** * Test that create_subscribers() returns a ClientException * when attempting to create subscribers, as this is only supported @@ -503,43 +306,6 @@ public function testCreateSubscribers() $result = $this->api->create_subscribers($subscribers); } - /** - * Test that create_subscribers() throws a ClientException when no data is specified. - * - * @since 2.2.0 - * - * @return void - */ - public function testCreateSubscribersWithBlankData() - { - $this->expectException(ClientException::class); - $result = $this->api->create_subscribers([ - [], - ]); - } - - /** - * Test that create_subscribers() throws a ClientException when invalid email addresses - * are specified, as this is only supported using OAuth. - * - * @since 2.2.0 - * - * @return void - */ - public function testCreateSubscribersWithInvalidEmailAddresses() - { - $this->expectException(ClientException::class); - $subscribers = [ - [ - 'email_address' => 'not-an-email-address', - ], - [ - 'email_address' => 'not-an-email-address-again', - ], - ]; - $result = $this->api->create_subscribers($subscribers); - } - /** * Test that create_custom_fields() throws a ClientException * as this is only supported using OAuth. @@ -572,40 +338,6 @@ public function testGetPurchases() $result = $this->api->get_purchases(); } - /** - * Test that get_purchases() throws a ClientException - * when the total count is included, as this is only - * supported using OAuth. - * - * @since 2.2.0 - * - * @return void - */ - public function testGetPurchasesWithTotalCount() - { - $this->expectException(ClientException::class); - $result = $this->api->get_purchases( - include_total_count: true - ); - } - - /** - * Test that get_purchases() throws a ClientException - * when pagination parameters and per_page limits are specified, - * as this is only supported using OAuth. - * - * @since 2.2.0 - * - * @return void - */ - public function testGetPurchasesPagination() - { - $this->expectException(ClientException::class); - $result = $this->api->get_purchases( - per_page: 1 - ); - } - /** * Test that get_purchases() throws a ClientException * when a purchase ID is specified, as this is only @@ -621,21 +353,6 @@ public function testGetPurchase() $result = $this->api->get_purchase(12345); } - /** - * Test that get_purchases() throws a ClientException when an invalid - * purchase ID is specified, as this is only supported - * using OAuth. - * - * @since 2.2.0 - * - * @return void - */ - public function testGetPurchaseWithInvalidID() - { - $this->expectException(ClientException::class); - $this->api->get_purchase(12345); - } - /** * Test that create_purchase() throws a ClientException * as this is only supported using OAuth. @@ -681,79 +398,4 @@ public function testCreatePurchase() transaction_time: new DateTime('now'), ); } - - /** - * Test that create_purchase() throws a ClientException when an invalid - * email address is specified, as this is only supported using OAuth. - * - * @since 2.2.0 - * - * @return void - */ - public function testCreatePurchaseWithInvalidEmailAddress() - { - $this->expectException(ClientException::class); - $this->api->create_purchase( - email_address: 'not-an-email-address', - transaction_id: str_shuffle('wfervdrtgsdewrafvwefds'), - currency: 'usd', - products: [ - [ - 'name' => 'Floppy Disk (512k)', - 'sku' => '7890-ijkl', - 'pid' => 9999, - 'lid' => 7777, - 'quantity' => 2, - 'unit_price' => 5.00, - ], - ], - ); - } - - /** - * Test that create_purchase() throws a ClientException when a blank - * transaction ID is specified, as this is only supported using OAuth. - * - * @since 2.2.0 - * - * @return void - */ - public function testCreatePurchaseWithBlankTransactionID() - { - $this->expectException(ClientException::class); - $this->api->create_purchase( - email_address: $this->generateEmailAddress(), - transaction_id: '', - currency: 'usd', - products: [ - [ - 'name' => 'Floppy Disk (512k)', - 'sku' => '7890-ijkl', - 'pid' => 9999, - 'lid' => 7777, - 'quantity' => 2, - 'unit_price' => 5.00, - ], - ], - ); - } - - /** - * Test that create_purchase() throws a ClientException when no products - * are specified, as this is only supported using OAuth. - * - * @since 2.2.0 - * - * @return void - */ - public function testCreatePurchaseWithNoProducts() - { - $this->expectException(ClientException::class); - $this->api->create_purchase( - email_address: $this->generateEmailAddress(), - transaction_id: str_shuffle('wfervdrtgsdewrafvwefds'), - currency: 'usd', - products: [], - ); - } } From 011f51664fa389ada6cf8ff859d823e9ae475d2c Mon Sep 17 00:00:00 2001 From: Tim Carr Date: Thu, 9 Oct 2025 19:26:55 +0800 Subject: [PATCH 2/2] Skip tests --- tests/ConvertKitAPIKeyTest.php | 203 +++++++++++++++++++++++++++++++++ 1 file changed, 203 insertions(+) diff --git a/tests/ConvertKitAPIKeyTest.php b/tests/ConvertKitAPIKeyTest.php index 16732f3..c3df735 100644 --- a/tests/ConvertKitAPIKeyTest.php +++ b/tests/ConvertKitAPIKeyTest.php @@ -246,6 +246,53 @@ public function testCreateTags() ]); } + /** + * Skip this test from ConvertKitAPITest, as testCreateTags() above + * confirms a ClientException is thrown. + * + * @since 2.2.0 + * + * @return void + */ + public function testCreateTagsBlank() + { + $this->markTestSkipped('testCreateTags() above confirms a ClientException is thrown.'); + } + + /** + * Skip this test from ConvertKitAPITest, as testCreateTags() above + * confirms a ClientException is thrown. + * + * @since 2.2.0 + * + * @return void + */ + public function testCreateTagsThatExist() + { + $this->markTestSkipped('testCreateTags() above confirms a ClientException is thrown.'); + } + + /** + * Test that tag_subscribers() throws a ClientException when attempting + * to tag subscribers, as this is only supported using OAuth. + * + * @since 2.2.0 + * + * @return void + */ + public function testTagSubscribers() + { + $this->expectException(ClientException::class); + $result = $this->api->tag_subscribers( + [ + [ + 'tag_id' => (int) $_ENV['CONVERTKIT_API_TAG_ID'], + 'subscriber_id' => (int) $_ENV['CONVERTKIT_API_SUBSCRIBER_ID'] + ], + ] + ); + } + /** * Test that add_subscribers_to_forms() throws a ClientException when * attempting to add subscribers to forms, as this is only supported @@ -283,6 +330,58 @@ public function testAddSubscribersToForms() ); } + /** + * Skip this test from ConvertKitAPITest, as testAddSubscribersToForms() above + * confirms a ClientException is thrown. + * + * @since 2.2.0 + * + * @return void + */ + public function testAddSubscribersToFormsWithReferrer() + { + $this->markTestSkipped('testAddSubscribersToForms() above confirms a ClientException is thrown.'); + } + + /** + * Skip this test from ConvertKitAPITest, as testAddSubscribersToForms() above + * confirms a ClientException is thrown. + * + * @since 2.2.0 + * + * @return void + */ + public function testAddSubscribersToFormsWithReferrerUTMParams() + { + $this->markTestSkipped('testAddSubscribersToForms() above confirms a ClientException is thrown.'); + } + + /** + * Skip this test from ConvertKitAPITest, as testAddSubscribersToForms() above + * confirms a ClientException is thrown. + * + * @since 2.2.0 + * + * @return void + */ + public function testAddSubscribersToFormsWithInvalidFormIDs() + { + $this->markTestSkipped('testAddSubscribersToForms() above confirms a ClientException is thrown.'); + } + + /** + * Skip this test from ConvertKitAPITest, as testAddSubscribersToForms() above + * confirms a ClientException is thrown. + * + * @since 2.2.0 + * + * @return void + */ + public function testAddSubscribersToFormsWithInvalidSubscriberIDs() + { + $this->markTestSkipped('testAddSubscribersToForms() above confirms a ClientException is thrown.'); + } + /** * Test that create_subscribers() returns a ClientException * when attempting to create subscribers, as this is only supported @@ -306,6 +405,32 @@ public function testCreateSubscribers() $result = $this->api->create_subscribers($subscribers); } + /** + * Skip this test from ConvertKitAPITest, as testCreateSubscribersWithBlankData() above + * confirms a ClientException is thrown. + * + * @since 2.2.0 + * + * @return void + */ + public function testCreateSubscribersWithBlankData() + { + $this->markTestSkipped('testCreateSubscribers() above confirms a ClientException is thrown.'); + } + + /** + * Skip this test from ConvertKitAPITest, as testCreateSubscribersWithBlankData() above + * confirms a ClientException is thrown. + * + * @since 2.2.0 + * + * @return void + */ + public function testCreateSubscribersWithInvalidEmailAddresses() + { + $this->markTestSkipped('testCreateSubscribers() above confirms a ClientException is thrown.'); + } + /** * Test that create_custom_fields() throws a ClientException * as this is only supported using OAuth. @@ -338,6 +463,32 @@ public function testGetPurchases() $result = $this->api->get_purchases(); } + /** + * Skip this test from ConvertKitAPITest, as testGetPurchases() above + * confirms a ClientException is thrown. + * + * @since 2.2.0 + * + * @return void + */ + public function testGetPurchasesWithTotalCount() + { + $this->markTestSkipped('testGetPurchases() above confirms a ClientException is thrown.'); + } + + /** + * Skip this test from ConvertKitAPITest, as testGetPurchases() above + * confirms a ClientException is thrown. + * + * @since 2.2.0 + * + * @return void + */ + public function testGetPurchasesPagination() + { + $this->markTestSkipped('testGetPurchases() above confirms a ClientException is thrown.'); + } + /** * Test that get_purchases() throws a ClientException * when a purchase ID is specified, as this is only @@ -353,6 +504,19 @@ public function testGetPurchase() $result = $this->api->get_purchase(12345); } + /** + * Skip this test from ConvertKitAPITest, as testGetPurchase() above + * confirms a ClientException is thrown. + * + * @since 2.2.0 + * + * @return void + */ + public function testGetPurchaseWithInvalidID() + { + $this->markTestSkipped('testGetPurchase() above confirms a ClientException is thrown.'); + } + /** * Test that create_purchase() throws a ClientException * as this is only supported using OAuth. @@ -398,4 +562,43 @@ public function testCreatePurchase() transaction_time: new DateTime('now'), ); } + + /** + * Skip this test from ConvertKitAPITest, as testCreatePurchase() above + * confirms a ClientException is thrown. + * + * @since 2.2.0 + * + * @return void + */ + public function testCreatePurchaseWithInvalidEmailAddress() + { + $this->markTestSkipped('testCreatePurchase() above confirms a ClientException is thrown.'); + } + + /** + * Skip this test from ConvertKitAPITest, as testCreatePurchase() above + * confirms a ClientException is thrown. + * + * @since 2.2.0 + * + * @return void + */ + public function testCreatePurchaseWithBlankTransactionID() + { + $this->markTestSkipped('testCreatePurchase() above confirms a ClientException is thrown.'); + } + + /** + * Skip this test from ConvertKitAPITest, as testCreatePurchase() above + * confirms a ClientException is thrown. + * + * @since 2.2.0 + * + * @return void + */ + public function testCreatePurchaseWithNoProducts() + { + $this->markTestSkipped('testCreatePurchase() above confirms a ClientException is thrown.'); + } }