New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch support #242

Merged
merged 1 commit into from Feb 3, 2019

Conversation

Projects
None yet
4 participants
@mbax
Copy link
Member

mbax commented Jan 1, 2019

Added support for IRCv3 batch:

  • Added events for a batch starting, adding messages to a batch, and a batch finishing.
  • Batched messages now supported by default. Client will not process batched messages until the declared end of a batch.
  • Renamed dobby boolean because it was causing too much confusion in reading.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 2, 2019

Codecov Report

Merging #242 into next will decrease coverage by 0.47%.
The diff coverage is 2.56%.

Impacted file tree graph

@@             Coverage Diff              @@
##               next     #242      +/-   ##
============================================
- Coverage     31.99%   31.51%   -0.48%     
  Complexity      523      523              
============================================
  Files           256      261       +5     
  Lines          4469     4537      +68     
  Branches        463      473      +10     
============================================
  Hits           1430     1430              
- Misses         2990     3058      +68     
  Partials         49       49
Impacted Files Coverage Δ Complexity Δ
.../irc/client/library/feature/CapabilityManager.java 100% <ø> (ø) 4 <0> (ø) ⬇️
...brary/event/abstractbase/ClientBatchEventBase.java 0% <0%> (ø) 0 <0> (?)
...teh/irc/client/library/util/BatchReferenceTag.java 0% <0%> (ø) 0 <0> (?)
...nt/library/event/client/ClientBatchStartEvent.java 0% <0%> (ø) 0 <0> (?)
...teh/irc/client/library/defaults/DefaultClient.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../library/event/client/ClientBatchMessageEvent.java 0% <0%> (ø) 0 <0> (?)
...ient/library/event/client/ClientBatchEndEvent.java 0% <0%> (ø) 0 <0> (?)
...ibrary/event/client/ClientReceiveCommandEvent.java 100% <100%> (ø) 1 <1> (ø) ⬇️
...ibrary/event/client/ClientReceiveNumericEvent.java 100% <100%> (ø) 2 <1> (ø) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7b5901...7bb8c90. Read the comment docs.

@mbax mbax force-pushed the next branch from 8f3c99e to f7b5901 Jan 13, 2019

@mbax mbax force-pushed the batch branch 2 times, most recently from af0167a to 8f0b45b Feb 2, 2019

@mbax mbax force-pushed the batch branch from 8f0b45b to f41411f Feb 2, 2019

@mbax mbax removed the work in progress label Feb 2, 2019

@mbax mbax force-pushed the batch branch from f41411f to 7bb8c90 Feb 2, 2019

@Zarthus

Zarthus approved these changes Feb 2, 2019

@mbax mbax merged commit 7bb8c90 into next Feb 3, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment