Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some twitch functionality that is needed an documented #277

Open
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@boostchicken
Copy link

commented Jul 7, 2019

Login Tag
Cumulative Months
Sub and Resub Msg-Ids

Adding some twitch functionality that is needed an documented
Login Tag
Cumulative Months
Sub and Resub Nsg-UIds
@codecov-io

This comment has been minimized.

Copy link

commented Jul 7, 2019

Codecov Report

Merging #277 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #277      +/-   ##
============================================
- Coverage     31.51%   31.45%   -0.07%     
  Complexity      551      551              
============================================
  Files           290      292       +2     
  Lines          4826     4836      +10     
  Branches        489      489              
============================================
  Hits           1521     1521              
- Misses         3258     3268      +10     
  Partials         47       47
Impacted Files Coverage Δ Complexity Δ
.../library/feature/twitch/event/UserNoticeEvent.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...lient/library/feature/twitch/messagetag/MsgId.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...re/twitch/messagetag/MsgParamCumulativeMonths.java 0% <0%> (ø) 0 <0> (?)
...c/client/library/feature/twitch/TwitchSupport.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...lient/library/feature/twitch/messagetag/Login.java 0% <0%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eb978a...f5ad7ca. Read the comment docs.

@lol768

lol768 approved these changes Jul 7, 2019

Update src/main/java/org/kitteh/irc/client/library/feature/twitch/mes…
…sagetag/MsgId.java

Co-Authored-By: Adam Williams <lol768@users.noreply.github.com>
@Zarthus

Zarthus approved these changes Jul 7, 2019

@mbax

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Thanks! Hoping to actually review this tomorrow. Just got back from a trip, and am pretty exhausted. Please don't consider my couple comments added to be my only thoughts on this :D

boostchicken added some commits Jul 8, 2019

@boostchicken

This comment has been minimized.

Copy link
Author

commented Jul 19, 2019

@mbax any progress?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.