From 160a1035d3c6807a86c76640c787f88279b766dc Mon Sep 17 00:00:00 2001
From: William Allen <william.allen@kitware.com>
Date: Fri, 17 Apr 2026 10:06:48 -0400
Subject: [PATCH] Rename commands page to "instrumentation

The distinction between the build commands page (which exclusively displays instrumentation data) and the build targets page (which is currently only useful if instrumentation data was submitted, but is intended to be used without instrumentation in the future) is currently unclear to users.  This PR renames the build commands page to build "instrumentation".
---
 app/Http/Controllers/BuildController.php                    | 4 ++--
 resources/js/vue/app.js                                     | 2 +-
 .../{BuildCommandsPage.vue => BuildInstrumentationPage.vue} | 0
 resources/js/vue/components/shared/BuildSidebar.vue         | 6 +++---
 routes/web.php                                              | 3 ++-
 tests/Browser/Pages/BuildSidebarComponentTest.php           | 2 +-
 6 files changed, 9 insertions(+), 8 deletions(-)
 rename resources/js/vue/components/{BuildCommandsPage.vue => BuildInstrumentationPage.vue} (100%)

diff --git a/app/Http/Controllers/BuildController.php b/app/Http/Controllers/BuildController.php
index 950c0a829e..ef4a523355 100644
--- a/app/Http/Controllers/BuildController.php
+++ b/app/Http/Controllers/BuildController.php
@@ -59,13 +59,13 @@ public function build(Request $request, int $build_id): View
         return $this->vue('build-build-page', 'Build', $params);
     }
 
-    public function commands(int $build_id): View
+    public function instrumentation(int $build_id): View
     {
         $this->setBuildById($build_id);
 
         $filters = json_decode(request()->query('filters')) ?? ['all' => []];
 
-        return $this->vue('build-commands-page', 'Commands', [
+        return $this->vue('build-instrumentation-page', 'Instrumentation', [
             'build-id' => $this->build->Id,
             'initial-filters' => $filters,
         ]);
diff --git a/resources/js/vue/app.js b/resources/js/vue/app.js
index 73dc8d26e7..1c8cb9bc4f 100755
--- a/resources/js/vue/app.js
+++ b/resources/js/vue/app.js
@@ -28,7 +28,7 @@ const app = Vue.createApp({
     UsersPage: Vue.defineAsyncComponent(() => import('./components/UsersPage.vue')),
     BuildFilesPage: Vue.defineAsyncComponent(() => import('./components/BuildFilesPage.vue')),
     BuildTargetsPage: Vue.defineAsyncComponent(() => import('./components/BuildTargetsPage.vue')),
-    BuildCommandsPage: Vue.defineAsyncComponent(() => import('./components/BuildCommandsPage.vue')),
+    BuildInstrumentationPage: Vue.defineAsyncComponent(() => import('./components/BuildInstrumentationPage.vue')),
     BuildBuildPage: Vue.defineAsyncComponent(() => import('./components/BuildBuildPage.vue')),
     CoverageFilePage: Vue.defineAsyncComponent(() => import('./components/CoverageFilePage.vue')),
     BuildCoveragePage: Vue.defineAsyncComponent(() => import('./components/BuildCoveragePage.vue')),
diff --git a/resources/js/vue/components/BuildCommandsPage.vue b/resources/js/vue/components/BuildInstrumentationPage.vue
similarity index 100%
rename from resources/js/vue/components/BuildCommandsPage.vue
rename to resources/js/vue/components/BuildInstrumentationPage.vue
diff --git a/resources/js/vue/components/shared/BuildSidebar.vue b/resources/js/vue/components/shared/BuildSidebar.vue
index f0668165bb..3f8c46c360 100644
--- a/resources/js/vue/components/shared/BuildSidebar.vue
+++ b/resources/js/vue/components/shared/BuildSidebar.vue
@@ -81,11 +81,11 @@
           data-test="sidebar-notes"
         />
         <build-sidebar-item
-          :href="`${$baseURL}/builds/${buildId}/commands`"
+          :href="`${$baseURL}/builds/${buildId}/instrumentation`"
           title="Instrumentation"
           :icon="FA.faGaugeHigh"
           :selected="activeTab === 'instrumentation'"
-          :disabled="commandsDisabled"
+          :disabled="instrumentationDisabled"
           data-test="sidebar-instrumentation"
         />
         <build-sidebar-item
@@ -255,7 +255,7 @@ export default {
     notesDisabled() {
       return !this.build || !this.build.notes || this.build.notes.pageInfo.total === 0;
     },
-    commandsDisabled() {
+    instrumentationDisabled() {
       return !this.build || !this.build.commands || this.build.commands.pageInfo.total === 0;
     },
     targetsDisabled() {
diff --git a/routes/web.php b/routes/web.php
index ade6ff374b..f7df6aff94 100755
--- a/routes/web.php
+++ b/routes/web.php
@@ -131,8 +131,9 @@
 Route::get('/builds/{build_id}/targets', 'BuildController@targets')
     ->whereNumber('build_id');
 
-Route::get('/builds/{build_id}/commands', 'BuildController@commands')
+Route::get('/builds/{build_id}/instrumentation', 'BuildController@instrumentation')
     ->whereNumber('build_id');
+Route::permanentRedirect('/build/{build_id}/commands', url('/builds/{build_id}/instrumentation'));
 
 Route::get('/builds/{build_id}/files', 'BuildController@files')
     ->whereNumber('build_id');
diff --git a/tests/Browser/Pages/BuildSidebarComponentTest.php b/tests/Browser/Pages/BuildSidebarComponentTest.php
index 6bf08b15f4..55f3728ae2 100644
--- a/tests/Browser/Pages/BuildSidebarComponentTest.php
+++ b/tests/Browser/Pages/BuildSidebarComponentTest.php
@@ -355,7 +355,7 @@ public function testInstrumentationItem(): void
                 'workingdirectory' => Str::uuid()->toString(),
             ]);
 
-            $this->assertNotDisabled($browser, "/builds/{$build->id}", '@sidebar-instrumentation', "/builds/{$build->id}/commands");
+            $this->assertNotDisabled($browser, "/builds/{$build->id}", '@sidebar-instrumentation', "/builds/{$build->id}/instrumentation");
         });
     }