Permalink
Commits on Jun 16, 2018
  1. Merge topic 'castxml-hashes'

    thewtex authored and kwrobot committed Jun 16, 2018
    4f3dbc5 BUG: Correct Windows and macOS CastXML hashes
  2. BUG: Correct Windows and macOS CastXML hashes

    thewtex committed Jun 16, 2018
    These were reversed.
    
    Change-Id: I4a58c65551ab3ad6ccd7ec384f087c6af08ccc4c
Commits on Jun 15, 2018
  1. Merge topic 'content-link-updates'

    thewtex authored and kwrobot committed Jun 15, 2018
    fc83c3b ENH: Update testing data content links
Commits on Jun 14, 2018
  1. ENH: Update testing data content links

    thewtex committed Jun 14, 2018
    Change-Id: I9cd757ecfa18b21e0ee7f50ef18a4ae995942b4c
  2. Merge topic 'emscripten-pthreads'

    thewtex authored and kwrobot committed Jun 14, 2018
    f2336c9 BUG: Do not use P-threads with Emscripten
  3. Merge topic 'HoughTransform-data-members-float-to-double'

    thewtex authored and kwrobot committed Jun 14, 2018
    ad41363 ENH: Changed type float data members HoughTransform filters to double
Commits on Jun 13, 2018
  1. Merge topic 'hough-transform-wrapping'

    thewtex authored and kwrobot committed Jun 13, 2018
    84f286f COMP: Remove extra argument from HoughTransform3DCircles wrapping
  2. COMP: Remove extra argument from HoughTransform3DCircles wrapping

    thewtex committed Jun 13, 2018
    This is a follow-up to 06afe0f where
    the third template parameter was removed.
    
    Change-Id: I197f8351062cb5b94b4c4188b94613fbf4309db5
  3. ENH: Changed type float data members HoughTransform filters to double

    N-Dekker committed Jun 13, 2018
    Improved floating point precision by changing the type of 32-bit
    'float' data members of HoughTransform2DCirclesImageFilter
    (DiscRadiusRatio, Variance, SweepAngle) and
    HoughTransform2DLinesImageFilter (AngleResolution, DiscRadius,
    Variance) to 64-bit 'double'.
    
    This improvement was inspired by the discussion at
    http://review.source.kitware.com/#/c/21814
    "STYLE: Improve itkHoughTransform2DLinesImageFilter style",
    by Jon Haitz Legarreta.
    
    Change-Id: I444010cbb9ae93e29072e0a6b6a27f65786009a9
  4. BUG: Do not use P-threads with Emscripten

    thewtex committed Jun 11, 2018
    Currently missing symbols.
    
    Change-Id: I07d3015f4ce3890dd434307f05641f05509f27f7
  5. Merge topic 'migrationGuideUpdate'

    thewtex authored and kwrobot committed Jun 13, 2018
    dc632cc DOC: merging instructions from itkMultiThreader.h into migration guide
  6. Merge topic 'Remove-default-HoughTransform2DCircles-RadiusPixelType'

    thewtex authored and kwrobot committed Jun 13, 2018
    06afe0f STYLE: Removed HoughTransform2DCircles default for TRadiusPixelType
  7. Merge topic 'exceptionobject-noexcept'

    thewtex authored and kwrobot committed Jun 13, 2018
    f245c24 ENH: Mark copy constructor of ExceptionObject and derived classes noexcept.
  8. ENH: Mark copy constructor of ExceptionObject and derived classes noe…

    Nekto89 authored and thewtex committed Jun 8, 2018
    …xcept.
    
    Mark SetDataObject and GetDataObject in DataObjectError noexcept.
    
    Change-Id: I7aabf17f352854c1a0b4a1a4bfeb0fc54e0f232f
  9. Merge topic 'CreateTestKernelLibrary'

    blowekamp authored and kwrobot committed Jun 13, 2018
    e45ceff ENH: Create TestKernel library
    0c9926b BUG: Fix incorrect library variable for MeshIO test drivers
    a465cb5 ENH: Remove  SPECIFIC_IMAGEIO_MODULE_TEST feature
    3437ae9 BUG: Add missing dependencies in Module testing
  10. Merge topic 'FixTHREADERtypeo'

    blowekamp authored and kwrobot committed Jun 13, 2018
    ab528b7 BUG: Fix name typo for ITK_GLOBAL_DEFAULT_THREADER
Commits on Jun 12, 2018
  1. DOC: merging instructions from itkMultiThreader.h into migration guide

    dzenanz committed Jun 8, 2018
    itkMultiThreader.h is a deprecated file and therefore slated for deletion
    sometime in the future. The migration guide is meant to be permanent.
    
    Change-Id: Ib40aaab4f73df2ac41f41a6324af4a8a6f3fe7f7
Commits on Jun 10, 2018
  1. STYLE: Removed HoughTransform2DCircles default for TRadiusPixelType

    N-Dekker committed Jun 10, 2018
    ITK 4.13 introduced TRadiusPixelType as an extra template parameter
    of HoughTransform2DCirclesImageFilter. It had a default argument,
    TRadiusPixelType = TOutputPixelType, for ITK4 backward compatibility.
    Unfortunately, this default argument is often not the right choice.
    For OutputPixelType, an unsigned integer is often preferable, whereas
    for RadiusPixelType, a floating point type is often a better choice.
    
    This commit removes the default argument from TRadiusPixelType,
    hoping to trigger ITK users to make the most appropriate choice.
    
    Change-Id: I34d8b543815192700ad01c04d9c37df256ae2639
Commits on Jun 8, 2018
  1. ENH: Create TestKernel library

    blowekamp committed Jun 7, 2018
    Create a library for the TesKernel code. Specifically, the code
    that explicitly registers the IO factories and performs the image
    comparisons is moved from header files to compiled code. Th
    removes the public dependencies for TestKernel module on the many of
    the ImageIO and their third party libraries, this reduces the includes
    paths and reduces compilation time by not recompiling this code for
    every test driver. Additionally, the image comparison code is now
    compiled into the library.
    
    Change-Id: Icbab45175993496d96c117dc0a61d227fad560ff
  2. BUG: Fix incorrect library variable for MeshIO test drivers

    blowekamp committed Jun 8, 2018
    Change-Id: Ia9ca7466a935d878326899b919d3cf92043dcf31
  3. BUG: Fix name typo for ITK_GLOBAL_DEFAULT_THREADER

    blowekamp committed Jun 8, 2018
    Change-Id: I8013bd7300773af1624377c6da1bf0c66834dfef
  4. ENH: Remove SPECIFIC_IMAGEIO_MODULE_TEST feature

    blowekamp committed Jun 7, 2018
    This define was not being properly used so it had no effect, in all
    cases but itkNrrdImageIOTest.cxx. ITK's factory registration system
    and modularity have improved so this feature is no longer needed.
    
    Change-Id: Ib4eec40a66e340c45d0b46521254af15314e4660
Commits on Jun 7, 2018
  1. Merge topic 'update_isotropic_wavelets'

    thewtex authored and kwrobot committed Jun 7, 2018
    c36f9fd COMP: Update IsotropicWavelets, remove FrequencyIterators
  2. Merge topic 'minorEnhancements'

    dzenanz authored and kwrobot committed Jun 7, 2018
    88b6a7a STYLE: initializing SingleMethod/SingleData in base class
    6632327 DOC: add compatibility warning to Barrier
    87005cb ENH: more thorough removal of deprecated "multiple method"
  3. STYLE: initializing SingleMethod/SingleData in base class

    dzenanz committed May 30, 2018
    Change-Id: I15dab801d272e9759cf043573072a1b2c160a7b0
  4. BUG: Add missing dependencies in Module testing

    blowekamp committed Jun 7, 2018
    These dependencies are explicitly missing, because they were
    satisfied by the transitive dependencies from the TestingKernel
    modules.
    
    Change-Id: I63f98b51a74663ec8a520c37e19033970e3efedb
  5. DOC: add compatibility warning to Barrier

    dzenanz authored and jhlegarreta committed May 31, 2018
    Change-Id: Ibed9a09c37cfea04e625f463ad27e485b062058d
Commits on Jun 6, 2018
  1. COMP: Update IsotropicWavelets, remove FrequencyIterators

    phcerdan committed Jun 6, 2018
    Remove the classes merged into the internal module ITKImageFrequency
    
    Change-Id: I5ec78adb2db011f3840d79d897d095e537bd2541
  2. Merge topic 'remove-midas3-for-release'

    thewtex authored and kwrobot committed Jun 6, 2018
    716fe07 BUG: Migrate midas3.kitware.com to data.kitware.com
  3. Merge topic 'frequency-iterators'

    thewtex authored and kwrobot committed Jun 6, 2018
    e16d0bc ENH: Add frequency iterators and band pass filter.
  4. Merge topic 'reverse-iterators-ShapedImageNeighborhoodRange'

    thewtex authored and kwrobot committed Jun 6, 2018
    35dd21a ENH: Added reverse iterators to ShapedImageNeighborhoodRange
  5. ENH: more thorough removal of deprecated "multiple method"

    dzenanz committed May 29, 2018
    Change-Id: Ic52130a8ae084e4ca160600adc2ec2c1c2878b73
  6. Merge topic 'dcmtk_canreadfile_perf'

    thewtex authored and kwrobot committed Jun 6, 2018
    7b1a896 PERF: improve DCMTKFileReader::CanReadFile perf
  7. PERF: improve DCMTKFileReader::CanReadFile perf

    ihnorton authored and thewtex committed Jun 4, 2018
    Using DcmMetaInfo avoids loading full dataset into memory, which
    can be very expensive for large files.
    For example, in Slicer, DCMTK is one of the first ITK readers tested.
    Without this change, attempting to read a multi-gigabyte NIfTI file
    will hang for many minutes in the ::CanReadFile code path. With this
    change, the test path completes in under 50ms.
    
    Change-Id: I7850f25ba92797489943c37ef72aeaf0588801d4
  8. ENH: Add frequency iterators and band pass filter.

    phcerdan committed May 1, 2018
    Initially developed for ITKIsotropicWavelets module [1].
    The associated Insight Journal article contains a descriptions of these
    iterators [2].
    The frequency iterators are ImageIterators with GetFrequency and
    GetFrequencyBins methods to abstract and ease development of filters in
    the frequency domain.
    
    Images in the frequency domain have layouts that depend on the
    algorithm that generates them, for example after a FFT, the zero
    frequency is at origin, max positive frequency is at index size/2 - 1.
    The min negative frequencies is size/2, and the least negative
    frequency is at index: size - 1.
    This layout change slightly if image is even or odd in size.
    (Nyquist bands appear).
    
    The best example is
    itkFrequencyFFTLayoutImageRegionConstIteratorWithIndex.h
    that contains the layout after applying the standard
    Fast Fourier Transform to an image.
    Also the Shifted version, that cover the common case
    of shifting the zero frequency to the center of the image.
    
    These iterators try to abstract this complexity from the developer, for
    them to only manipulate frequency values. The best example is the
    FrequencyBandFilter, that acts as BandPass or BandStop filter given two
    boundary frequencies.
    
    The base classes of this hierarchy of iterators handle
    the case where images are taken
    in frequency space (scattering experiments for example),
    and they are just regular ImageIterator with the GetFrequency
    functions.
    
    Note: The frequency iterator for hermitian images is not included
    (FFT of real images can be chopped by half because they contain
    redundant information)
    
    Also at the time of developing I triggered this question in the
    mail-list about the lack of meaning of image metadata after performing
    a FFT: [3]
    
    [1]: https://github.com/phcerdan/ITKIsotropicWavelets/
    [2]: http://www.insight-journal.org/browse/publication/986
    [3]: https://public.kitware.com/pipermail/community/2017-May/013055.html
    
    Change-Id: Ie29319eb66cd0dd9f95545396faa7df9226a9364