Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes various warnings #4

Merged
merged 4 commits into from Mar 11, 2015
Merged

Fixes various warnings #4

merged 4 commits into from Mar 11, 2015

Conversation

seanm
Copy link
Contributor

@seanm seanm commented Mar 11, 2015

Fixes various warnings

Fixes clang -Wpotentially-evaluated-expression
warning.
Fixes clang -Wreserved-id-macro warnings
@thewtex
Copy link
Member

thewtex commented Mar 11, 2015

👍 Thanks for the contribution!

LGTM

Built fine locally.

thewtex added a commit that referenced this pull request Mar 11, 2015
Fixes various warnings
@thewtex thewtex merged commit aea9120 into Kitware:master Mar 11, 2015
@seanm
Copy link
Contributor Author

seanm commented Mar 11, 2015

Thx. Who do I pester to get this into VTK?

@thewtex
Copy link
Member

thewtex commented Mar 11, 2015

It will be in ITK, soon :-).

To get it into VTK, I would ping the lists and @demarle and @mathstuf

@thewtex
Copy link
Member

thewtex commented Mar 11, 2015

PS. If you wanted to get it into ITK, we have a script,

./Modules/ThirdParty/MetaIO/src/UpdateMetaIOFromUpstream.sh

This makes it low-overhead to perform updates, and it allows any contributor perform the upgrade. I don't know if one exists in VTK yet -- if not, it is a good idea to create one ;-).

@demarle
Copy link
Contributor

demarle commented Mar 12, 2015

Thanks Matt! I look forward to stealing that script into VTK.

David E DeMarle
Kitware, Inc.
R&D Engineer
21 Corporate Drive
Clifton Park, NY 12065-8662
Phone: 518-881-4909

On Wed, Mar 11, 2015 at 4:44 PM, Matt McCormick notifications@github.com
wrote:

PS. If you wanted to get it into ITK, we have a script,

./Modules/ThirdParty/MetaIO/src/UpdateMetaIOFromUpstream.sh

This makes it low-overhead to perform updates, and it allows any
contributor perform the upgrade. I don't know if one exists in VTK yet --
if not, it is a good idea to create one ;-).


Reply to this email directly or view it on GitHub
#4 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants