From 5f2018eb4a0e9c5144dafe86b65ca45f98e95d49 Mon Sep 17 00:00:00 2001
From: Brandon Davis <brandon.davis@kitware.com>
Date: Mon, 8 Mar 2021 12:44:02 -0500
Subject: [PATCH 1/3] Fix #595

---
 client/platform/desktop/frontend/components/Jobs.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/platform/desktop/frontend/components/Jobs.vue b/client/platform/desktop/frontend/components/Jobs.vue
index 53dcb2e91..604c67831 100644
--- a/client/platform/desktop/frontend/components/Jobs.vue
+++ b/client/platform/desktop/frontend/components/Jobs.vue
@@ -138,7 +138,7 @@ export default defineComponent({
                       class="pr-2"
                     >
                       mdi-console
-                    </v-icon> View Output
+                    </v-icon> View Console Log
                   </v-btn>
                 </v-col>
               </v-row>

From 87bad43c533cd34b55a4d680740db91486bd9914 Mon Sep 17 00:00:00 2001
From: Brandon Davis <brandon.davis@kitware.com>
Date: Mon, 8 Mar 2021 16:43:18 -0500
Subject: [PATCH 2/3] Launch job folder, toggle logs, scroll

---
 .../desktop/frontend/components/Jobs.vue      | 64 +++++++++++++++++--
 1 file changed, 58 insertions(+), 6 deletions(-)

diff --git a/client/platform/desktop/frontend/components/Jobs.vue b/client/platform/desktop/frontend/components/Jobs.vue
index 604c67831..3729cff79 100644
--- a/client/platform/desktop/frontend/components/Jobs.vue
+++ b/client/platform/desktop/frontend/components/Jobs.vue
@@ -1,9 +1,12 @@
 <script lang="ts">
+import { shell } from 'electron';
 import moment, { utc } from 'moment';
 import { defineComponent, ref, onBeforeUnmount } from '@vue/composition-api';
+
+import { DesktopJob } from 'platform/desktop/constants';
+
 import BrowserLink from './BrowserLink.vue';
 import NavigationBar from './NavigationBar.vue';
-
 import { datasets } from '../store/dataset';
 import { recentHistory } from '../store/jobs';
 
@@ -22,6 +25,20 @@ export default defineComponent({
     }, 1000);
     onBeforeUnmount(() => clearInterval(clockDriverInterval));
 
+    const truncateOutputAtLines = 500;
+
+    function toggleVisibleOutput(job: DesktopJob) {
+      if (job.key === visibleOutput.value) {
+        visibleOutput.value = null;
+      } else {
+        visibleOutput.value = job.key;
+      }
+    }
+
+    async function openPath(job: DesktopJob) {
+      shell.openPath(job.workingDir);
+    }
+
     return {
       clockDriver,
       datasets,
@@ -29,6 +46,10 @@ export default defineComponent({
       moment,
       utc,
       visibleOutput,
+      truncateOutputAtLines,
+      /* methods */
+      openPath,
+      toggleVisibleOutput,
     };
   },
 });
@@ -46,7 +67,7 @@ export default defineComponent({
               Job History ({{ recentHistory.length }})
             </h1>
             <v-card
-              v-for="job in recentHistory"
+              v-for="job in recentHistory.slice().reverse()"
               :key="job.job.key"
               class=" mb-4"
               min-width="100%"
@@ -101,6 +122,15 @@ export default defineComponent({
                           {{ job.job.datasetIds.join(', ') }}
                         </td>
                       </tr>
+                      <tr>
+                        <td>work dir</td>
+                        <td
+                          class="selectable"
+                          @click="openPath(job.job)"
+                        >
+                          show in file manager
+                        </td>
+                      </tr>
                     </table>
                   </v-card-subtitle>
                 </v-col>
@@ -131,14 +161,14 @@ export default defineComponent({
                     text
                     small
                     class="mb-2 primary--text text--lighten-3 text-decoration-none"
-                    @click="visibleOutput = job.job.key"
+                    @click="toggleVisibleOutput(job.job)"
                   >
                     <v-icon
                       color="primary lighten-3"
                       class="pr-2"
                     >
                       mdi-console
-                    </v-icon> View Console Log
+                    </v-icon> {{ job.job.key === visibleOutput ? 'Hide' : 'Show' }} Console Log
                   </v-btn>
                 </v-col>
               </v-row>
@@ -152,14 +182,27 @@ export default defineComponent({
                   rounded
                   color="black"
                   min-width="100%"
+                  height="220"
                   class="px-4 py-1"
+                  style="overflow-y: auto;"
                 >
                   <p
-                    v-for="(line, i) in job.logs.slice(-10, -1)"
+                    v-for="(line, i) in job.logs.slice(-1 * truncateOutputAtLines, -1).reverse()"
                     :key="line + i"
                     class="my-1 terminal"
                   >
-                    {{ line.replace('\n', '') }}
+                    {{ job.logs.length - i - 1 }}. {{ line.replace('\n', '') }}
+                  </p>
+                  <p
+                    v-if="job.logs.length > truncateOutputAtLines"
+                    class="my-1 terminal terminal-meta"
+                  >
+                    ______________________________
+                    <br><br>
+                    Logging truncated at {{ truncateOutputAtLines }} most recent lines.
+                    See job working directory for full console log.
+                    <br>
+                    {{ job.job.workingDir }}
                   </p>
                 </v-card>
               </v-row>
@@ -176,7 +219,16 @@ export default defineComponent({
   font-family: monospace;
   font-size: 12px;
 }
+.terminal-meta {
+  opacity: 0.7;
+}
 td {
   padding-right: 20px;
 }
+.selectable {
+  cursor: pointer;
+}
+.selectable:hover {
+  opacity: 0.8;
+}
 </style>

From 5c7c86b7cada97956934c619396a77d6d1212912 Mon Sep 17 00:00:00 2001
From: Brandon Davis <brandon.davis@kitware.com>
Date: Mon, 8 Mar 2021 17:40:55 -0500
Subject: [PATCH 3/3] More clickableness

---
 client/platform/desktop/frontend/components/Jobs.vue | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/client/platform/desktop/frontend/components/Jobs.vue b/client/platform/desktop/frontend/components/Jobs.vue
index 3729cff79..dd2b5667d 100644
--- a/client/platform/desktop/frontend/components/Jobs.vue
+++ b/client/platform/desktop/frontend/components/Jobs.vue
@@ -128,7 +128,13 @@ export default defineComponent({
                           class="selectable"
                           @click="openPath(job.job)"
                         >
-                          show in file manager
+                          <span class="text-decoration-underline">show in file manager</span>
+                          <v-icon
+                            small
+                            class="mx-2"
+                          >
+                            mdi-folder-open
+                          </v-icon>
                         </td>
                       </tr>
                     </table>