Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MongoDB Rework #43

Merged
merged 9 commits into from
Jan 18, 2016
Merged

MongoDB Rework #43

merged 9 commits into from
Jan 18, 2016

Conversation

opadron
Copy link
Contributor

@opadron opadron commented Dec 29, 2015

More and more, I'm finding that simple updates to GoBig seldom turn out so simple. This PR, originally meant as just a fix to #42, is a testament to this observation.

Once I switched the mongodb roles to being proper roles (as opposed to dumb wrappers around apt), I knew I needed to add configuration options to meet the inevitably varied needs of those who might want to use them. The more I dug into the docs, though, the more apparent the need to cover use cases requiring replica sets and sharding became.

This code is indeed a WIP, but it should help others to see what I'm going for.

@opadron
Copy link
Contributor Author

opadron commented Dec 29, 2015

@kotfic PTAL. I don't have access to any resources that I can test this on. Could I send you some playbooks to try on AWS? Hopefully, this shouldn't require much more work to handle the simple case of just installing a stand alone MongoDB.

@kotfic
Copy link
Contributor

kotfic commented Dec 29, 2015

@opadron do you have a motivating use-case for the sharding and replication set work? I can deploy to some virtual machines locally to test these out, but they are features of mongo that I am not particularly familiar with, I'll need a pretty straightforward use-case and test playbook.

@opadron
Copy link
Contributor Author

opadron commented Jan 4, 2016

For now, I think the current example playbook should be enough to reproduce a standalone install of mongo (with a newer version than what's in ubuntu's repos).

  - hosts: mongodb
    roles:
      - role: mongodb
        state: started

@opadron
Copy link
Contributor Author

opadron commented Jan 17, 2016

@Kitware/gobig Ready for review.

@kotfic
Copy link
Contributor

kotfic commented Jan 18, 2016

@opadron looks like there are some string mangling issues (there is a \n in the download url)?

TASK: [mongodb-install | mongodb | pkg | download] **************************** 
<127.0.0.1> REMOTE_MODULE command creates=/opt/mongodb/mongodb-3.2.0.tar.gz curl -o "/opt/mongodb/mongodb-3.2.0.tar.gz" "https://fastdl.mongodb.org/linux/mongodb-linux-x86_64- 3.2.0.tgz"
failed: [minerva] => {"changed": true, "cmd": ["curl", "-o", "/opt/mongodb/mongodb-3.2.0.tar.gz", "https://fastdl.mongodb.org/linux/mongodb-linux-x86_64-\n3.2.0.tgz"], "delta": "0:00:00.012142", "end": "2016-01-18 15:34:49.200065", "rc": 3, "start": "2016-01-18 15:34:49.187923", "warnings": ["Consider using get_url module rather than running curl"]}
stderr: curl: (3) Illegal characters found in URL

FATAL: all hosts have already failed -- aborting

@opadron
Copy link
Contributor Author

opadron commented Jan 18, 2016

Fixed. Apparently, when you use syntax like the one below for a string block:

my_string: >
    long string that I didn't expect to have a newline at the end

you get a newline tacked onto the end.

Someday, I will understand YAML's syntax. I can dream.

@kotfic
Copy link
Contributor

kotfic commented Jan 18, 2016

ansible script is now completing but mongod is throwing an error. From /var/log/mongodb.log:

Error parsing YAML config file: yaml-cpp: error at line 4, column 4: end of map not found
try '/opt/mongodb/3.2.0/bin/mongod --help' for more information

@opadron
Copy link
Contributor Author

opadron commented Jan 18, 2016

@kotfic PTAL

@kotfic
Copy link
Contributor

kotfic commented Jan 18, 2016

@opadron LGTM!

opadron added a commit that referenced this pull request Jan 18, 2016
@opadron opadron merged commit 5b8f361 into Kitware:master Jan 18, 2016
@opadron opadron deleted the mongodb-rework branch February 3, 2016 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants