Skip to content

Do not ship node_modules folder with package #40

@FezVrasta

Description

@FezVrasta

Hi, right now this package ships its own node_modules folder.

This is a problem under several aspects, you should let the package manager read your package.json and let it download and link the require dependencies in the proper folder.

Right now this is breaking esbuild, Yarn "patch", and any npm/yarn/pnpm install command (because they can't resolve to a single version of the packages in your node_modules since they aren't able to touch them) and probably many other tools. For the same reason, bundles aren't able to reuse compatible versions of the same package but they need to ship them twice. And it breaks users expectations.

More info rollup/rollup#3684 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions