From 055936f295c87876f99bf774f23c833f5921ff97 Mon Sep 17 00:00:00 2001 From: Forrest Li Date: Wed, 22 Feb 2023 11:35:48 -0500 Subject: [PATCH 1/3] chore(github): run release on beta push --- .github/workflows/publish.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml index 7f126a6..b9be7e2 100644 --- a/.github/workflows/publish.yaml +++ b/.github/workflows/publish.yaml @@ -3,6 +3,7 @@ on: push: branches: - master + - beta jobs: publish: From 4aa322cad0544d50fb5d008392bdf628aa7e2a6e Mon Sep 17 00:00:00 2001 From: Aaron Maynard Date: Wed, 1 Mar 2023 01:12:19 -0330 Subject: [PATCH 2/3] feat(vtk.js): update vtk.js to 26.8.0 --- package.json | 2 +- usage/package-lock.json | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index cd064fb..378a639 100644 --- a/package.json +++ b/package.json @@ -42,7 +42,7 @@ "dev": "rollup ./src/index.js -c --watch" }, "peerDependencies": { - "@kitware/vtk.js": "^26.5.3", + "@kitware/vtk.js": "^26.8.0", "react": "^16.0.0" }, "devDependencies": { diff --git a/usage/package-lock.json b/usage/package-lock.json index 6f62b37..5a196e9 100644 --- a/usage/package-lock.json +++ b/usage/package-lock.json @@ -28,7 +28,7 @@ "@babel/plugin-transform-runtime": "^7.12.10", "@babel/preset-env": "^7.12.11", "@babel/preset-react": "^7.12.10", - "@kitware/vtk.js": "^26.5.3", + "@kitware/vtk.js": "^26.8.0", "@rollup/plugin-babel": "^5.2.2", "@rollup/plugin-commonjs": "17.0.0", "@rollup/plugin-eslint": "^8.0.1", @@ -58,7 +58,7 @@ "semantic-release": "17.3.1" }, "peerDependencies": { - "@kitware/vtk.js": "^26.5.3", + "@kitware/vtk.js": "^26.8.0", "react": "^16.0.0" } }, From 0c0722f3b7cbb751a2fc911612a599cf03c333d4 Mon Sep 17 00:00:00 2001 From: Vasily Kiniv Date: Mon, 27 May 2024 01:00:24 +0300 Subject: [PATCH 3/3] fix(view.js): fix crash on style.delete() when `interactive` prop is set to `false` When `interactive` prop is set to `false`, `this.style` remains null, but component's `componentWillUnmount` method still tries to delete and crash. --- src/core/View.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/core/View.js b/src/core/View.js index ac48c01..de572b9 100644 --- a/src/core/View.js +++ b/src/core/View.js @@ -427,10 +427,12 @@ export default class View extends Component { this.interactor.setInteractorStyle(null); } - this.style.delete(); + if (this.style) { + this.style.delete(); + this.style = null; + } this.defaultStyle.delete(); this.defaultStyle = null; - this.style = null; this.renderer = null; this.selector = null; this.orientationWidget = null;