From e18cd85493c2adb8c2502d74ce2004cea5f29904 Mon Sep 17 00:00:00 2001 From: Aaron Maynard Date: Mon, 28 Nov 2022 00:32:57 -0330 Subject: [PATCH] fix(GeometryRepresentation): Allow setting of cubeAxesStyle when cubeAxes is initialized in constructor --- src/core/GeometryRepresentation.js | 9 ++++++--- usage/package-lock.json | 6 +++--- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/core/GeometryRepresentation.js b/src/core/GeometryRepresentation.js index 54d9a43..6069118 100644 --- a/src/core/GeometryRepresentation.js +++ b/src/core/GeometryRepresentation.js @@ -191,14 +191,17 @@ export default class GeometryRepresentation extends Component { this.lookupTable.updateRange(); } - if (showCubeAxes && this.cubeAxes == null) { - changed = true; - this.initCubeAxes(); + if (showCubeAxes) { + if (this.cubeAxes == null) { + changed = true; + this.initCubeAxes(); + } if ( cubeAxesStyle && (!previous || cubeAxesStyle !== previous.cubeAxesStyle) ) { + changed = true; this.cubeAxes.set(cubeAxesStyle); } } diff --git a/usage/package-lock.json b/usage/package-lock.json index 25b1f33..b837015 100644 --- a/usage/package-lock.json +++ b/usage/package-lock.json @@ -27,7 +27,7 @@ "@babel/plugin-transform-runtime": "^7.12.10", "@babel/preset-env": "^7.12.11", "@babel/preset-react": "^7.12.10", - "@kitware/vtk.js": "^24.3.1", + "@kitware/vtk.js": "^24.17.0", "@rollup/plugin-babel": "^5.2.2", "@rollup/plugin-commonjs": "17.0.0", "@rollup/plugin-eslint": "^8.0.1", @@ -57,7 +57,7 @@ "semantic-release": "17.3.1" }, "peerDependencies": { - "@kitware/vtk.js": "^24.3.1", + "@kitware/vtk.js": "^24.17.0", "react": "^16.0.0" } }, @@ -2136,7 +2136,7 @@ "@babel/preset-env": "^7.12.11", "@babel/preset-react": "^7.12.10", "@babel/runtime": "^7.12.5", - "@kitware/vtk.js": "^24.3.1", + "@kitware/vtk.js": "^24.17.0", "@rollup/plugin-babel": "^5.2.2", "@rollup/plugin-commonjs": "17.0.0", "@rollup/plugin-eslint": "^8.0.1",