Skip to content

fix(IFCImporter): optimize IFC parsing #3368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(IFCImporter): optimize IFC parsing #3368

wants to merge 1 commit into from

Conversation

@daker
Copy link
Collaborator

@daker daker commented Nov 24, 2025 •
edited
Loading

Context

Results

Changes

  • Documentation and TypeScript definitions were updated to match those changes

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds or fixes unit tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

finetjul
finetjul approved these changes Nov 24, 2025
View reviewed changes
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it really change performance ?

@daker
Copy link
Collaborator Author

daker commented Nov 24, 2025

Not exactly, i just changed it to avoid declaring an array inside the loop(as you stated many time 😄)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@finetjul finetjul finetjul approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@daker @finetjul