New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude VR view from main layout management #18

Closed
cpinter opened this Issue Jan 17, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@cpinter
Copy link
Collaborator

cpinter commented Jan 17, 2018

Node reference parentLayoutNodeID in view nodes

  • None by default, meaning main layout. Set to node (e.g. itself) to indicate it’s standalone and should not be managed
  • Abstract layout node class
    • Current layout node and the new VR layout node will be its child classes
    • VR “layout” may contain HUD-like objects such as slice views or charts that are positioned and kept stationary in the VR view by the layout
@cpinter

This comment has been minimized.

Copy link
Collaborator

cpinter commented Jan 17, 2018

@jcfr Please assign this to me (or give me right to do it). Thanks!

@jcfr

This comment has been minimized.

Copy link
Contributor

jcfr commented Jan 17, 2018

Please assign this to me (or give me right to do it). Thanks!

All set. Also you know have push access to the repo.

@cpinter

This comment has been minimized.

Copy link
Collaborator

cpinter commented Jan 17, 2018

Perfect, thank you!

@cpinter

This comment has been minimized.

Copy link
Collaborator

cpinter commented Feb 3, 2018

Integrated in Slicer/Slicer@2e31656

I just opened a PR to SlicerOpenVR: #20

After this (and after solving the extension packaging issues) SlicerOpenVR will work with Slicer master as is.

@jcfr

This comment has been minimized.

Copy link
Contributor

jcfr commented Feb 6, 2018

Closing. This was fixed in 6308d6a

@jcfr jcfr closed this Feb 6, 2018

adamrankin added a commit to adamrankin/Slicer that referenced this issue Mar 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment