New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable an install target #74
Conversation
Should work fine on Unix systems, and support install prefixes. Installs both a static and a shared library to the same location, so we get an .a and a .so/.dylib file, which can be linked to in the ordinary way, ie. `-lg3logger`.
# Check the output result and install accordingly. | ||
# ========================================================================== | ||
# INCLUDE (${g3log_SOURCE_DIR}/CPackLists.txt) | ||
INCLUDE (${g3log_SOURCE_DIR}/CPackLists.txt) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see comment in CPackLists.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed in a coming pull request
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @duedal |
FYI :make install worked great on linux |
@duedal please make a comment when this is ready to be re-reviewed. |
@duedal did you see my review comments? |
@KjellKod I did yes, things just been a bit crazy at work so havn't had the time to make the required changes yet. 😔 I'm going to work on this during the weekend. We need to make sure we don't break anything on windows for sure. I don't know about |
No worries. If it's too hectic right now I can always make a pull request to your pull request. You can review it and if all is OK you merge it to your branch "install-target" and it will show up here (on this pull request). It sounds complicated but is really straight forward. |
@duedal |
@duedal, aha and you are the culprit too ;) Homebrew/legacy-homebrew@a8114e1#Library/Formula/g3log.rb Thanks man! |
taken over by pull request: #83 to address the comments above |
@duedal, please see release 1.2 of g3log What is needed to update the OSX brew install with this? Contact Information E-mail: Hedstrom@KjellKod.cc On Wed, Feb 17, 2016 at 1:41 AM, Hans Duedal notifications@github.com
|
Hi. Sorry I haven't been able to commit the time to work with CPack. For the next release, could you enable CPack on OS X too? Something like.
|
Sent a PR to homebrew with the 1.2 release. |
I see the PR was closed and not merged (?). Anything I can do to help? What went wrong? Sent from my iPhone
|
They do signed commits, it was "merged" in this commit: Homebrew/legacy-homebrew@39974fd |
OK. Cool. Thanks Contact Information E-mail: Hedstrom@KjellKod.cc On Tue, Mar 8, 2016 at 7:43 AM, Hans Duedal notifications@github.com
|
Should work fine on Unix systems, and support install prefixes.
Installs both a static and a shared library to the same location, so we get an .a and a .so/.dylib file, which can be linked to in the ordinary way, ie.
-lg3logger
.As discussed in #49
More work could be done, but for now I think we need some basic support added.