Check if Message.get_params return 3-tuple instead of str on parse_options_header#79
Merged
Kludex merged 4 commits intoKludex:masterfrom Feb 9, 2024
Merged
Conversation
bdenglish
approved these changes
Feb 7, 2024
Contributor
Author
|
Hey @Kludex, would you mind reviewing these changes? It's a pretty simple two-line fix. |
Kludex
reviewed
Feb 9, 2024
Contributor
Author
|
Sounds good! Thanks for your help! |
tiangolo
approved these changes
Feb 9, 2024
Contributor
tiangolo
left a comment
tiangolo
left a comment
There was a problem hiding this comment.
Great, thanks @lorenpike! I didn't notice that. 🤓
1 task
Kludex
approved these changes
Feb 9, 2024
Kludex
changed the title
Message.get_params return 3-tuple instead of str on parse_options_header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the case where
email.message.Message.get_paramsreturns a 3-tupleinstead of astrFor more context on the bug, here's the definition for
Message.get_params