Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add knapsack binary #21

Merged
merged 1 commit into from Jul 20, 2015
Merged

Add knapsack binary #21

merged 1 commit into from Jul 20, 2015

Conversation

@strika
Copy link
Contributor

@strika strika commented Jul 20, 2015

Artur, thanks for the great work with Knapsack.

I'm interested if you're open to including the knapsack executable? Let me explain my motivation. I did some experimentation with Knapsack where I didn't use Knapsack to generate RSpec report. Instead, I generated the report from some other reports that I collect about specs. Then I used the manually built Knapsack report to run specs in parallel.

In this setup, Knapsack doesn't need to be included in the Gemfile. Instead, I can install Knapsack globally on the build machine and reuse it for all projects that I have. Do you think this can be interesting to a wider audience?

The PR implementation might not be the best, but it illustrates the idea. I can install gem globally and execute RSpec with knapsack rspec.

What do you think about this? Thanks.

@ArturT
Copy link
Member

@ArturT ArturT commented Jul 20, 2015

@strika Thanks for PR. I will add case for cucumber, minitest and update read me then release new gem version.

ArturT added a commit that referenced this pull request Jul 20, 2015
Add knapsack binary
@ArturT ArturT merged commit e7df2ec into KnapsackPro:master Jul 20, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants