Fix for issue #209 #213

Open
wants to merge 1 commit into
from

Projects

None yet

2 participants

@rpallas
rpallas commented Mar 4, 2013

Added a check to make sure the selection column doesn't exist before adding it.

@rpallas rpallas Prevents duplication of the selection column.
Added a check to make sure the selection column doesn't exist before adding it.
884c636
@dotNetFollower

It seems to be never applied to the main branch since the project looks abandoned. I however still try to avoid 3rd party source code changing, so here is an alternative solution wrapped into custom binding:

ko.bindingHandlers["koGridFixed"] = {
   init: function (element, valueAccessor, allBindingsAccessor, data, context) {
      var gridOptions = ko.utils.unwrapObservable(valueAccessor());
      if (gridOptions && gridOptions.columnDefs) {
         var columnDefsArr = ko.utils.unwrapObservable(gridOptions.columnDefs);
         if (columnDefsArr && columnDefsArr.length > 0 && columnDefsArr[0].field === '\u2714')
            columnDefsArr.splice(0, 1);
      }
 
      return ko.bindingHandlers["koGrid"].init(element, valueAccessor, allBindingsAccessor, data, context);
   }
};

The koGrid binding should be replaced with koGridFixed across the views. Some additional details are here - koGrid: Bug – Checkboxes column duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment