New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to knotx template engine #32

Merged
merged 14 commits into from Dec 3, 2018

Conversation

Projects
None yet
2 participants
@Skejven
Copy link
Member

Skejven commented Nov 30, 2018

Description

Replace HBS Knot with Template Engine.

Motivation and Context

HBS Knot is outdated implementation, it will be replaced by dedicated module Knot.x Template Engine.

Cluster update in progress...

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the Knot.x Contributor License Agreement.

Skejven and others added some commits Nov 28, 2018

Merge remote-tracking branch 'origin/feature/switch-to-knotx-template…
…-engine' into feature/update-cluster-to-template-engine
Merge remote-tracking branch 'origin/feature/switch-to-knotx-template…
…-engine' into feature/update-cluster-to-template-engine
Merge pull request #33 from Knotx/feature/update-cluster-to-template-…
…engine

Remove mocks from cluster, replace with httpd image, add template engine
Fixing syntax issue in knotx-stack.json, fixing domain/port in sample…
… services configuration, temporary fix with if-modified-since for remote content.
@tomaszmichalak

This comment has been minimized.

Copy link
Contributor

tomaszmichalak commented Dec 3, 2018

Validated with Acme Stack and Acme Cluster.

@tomaszmichalak tomaszmichalak merged commit 2da9397 into master Dec 3, 2018

3 checks passed

CodeFactor 5 issues fixed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tomaszmichalak tomaszmichalak deleted the feature/switch-to-knotx-template-engine branch Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment