New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract assembler and splitter EB addresses to globals. #32

Merged
merged 2 commits into from Nov 21, 2018

Conversation

Projects
None yet
2 participants
@tomaszmichalak
Copy link
Contributor

tomaszmichalak commented Nov 21, 2018

Configuration cleanup.

Description

Extract assembler and splitter EB addresses to globals.

Motivation and Context

Assembler & Splitter address used in two places - it was not clear without variables in globals.

Upgrade notes (if appropriate)

No changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the Knot.x Contributor License Agreement.

@tomaszmichalak tomaszmichalak merged commit 7ca0d12 into master Nov 21, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tomaszmichalak tomaszmichalak deleted the bugfix/configuration-cleanup branch Nov 21, 2018

@tomaszmichalak tomaszmichalak restored the bugfix/configuration-cleanup branch Nov 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment