Feature/switch to knotx template engine #33

malaskowski · 2018-11-29T14:37:03Z

Description

Replace HBS Knot with Template Engine

Motivation and Context

HBS Knot is outdated implementation, it will be replaced by dedicated module Knot.x Template Engine

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.

I hereby agree to the terms of the Knot.x Contributor License Agreement.

tomaszmichalak · 2018-11-30T09:08:19Z

...t-tests/src/test/java/io/knotx/example/monolith/SampleApplicationHeadersIntegrationTest.java

@@ -77,7 +77,7 @@ public void before() {
    expectedHeaders.clear();
    expectedHeaders.add("Access-Control-Allow-Origin", "*");
    expectedHeaders.add("Content-Type", "text/html; charset=UTF-8");
-    expectedHeaders.add("content-length", "2995");
+    expectedHeaders.add("content-length", "2971");


Can we check if that header exists instead of the value?

tomaszmichalak · 2018-11-30T09:11:47Z

knotx-it-tests/src/test/resources/content/local/customAndDefaultSymbol.html

@@ -42,7 +42,7 @@ <h2>
    </div>
  </div>
  <div class="row">
-    <script data-knotx-knots="databridge,handlebars"
+    <script data-knotx-knots="databridge,te"


Can we simplify this test to one service invocation, we test databridge namespaces in module tests.

tomaszmichalak · 2018-11-30T09:13:37Z

knotx-it-tests/src/test/resources/content/local/customAndDefaultSymbol.html

@@ -56,9 +56,7 @@ <h2>Snippet1 - {[_result.message]}</h2>
      <div class="col-md-4">
        <h2>Snippet1 - {[second._result.message]}</h2>


Can we make the custom simple more visible like &&value&& instead of {[value]}.

Actually it makes more sense to move tests with custom delimiter to knotx-template-engine module.

tomaszmichalak · 2018-11-30T09:15:42Z

knotx-it-tests/src/test/resources/content/local/customAndDefaultSymbol.html

@@ -42,7 +42,7 @@ <h2>
    </div>
  </div>
  <div class="row">
-    <script data-knotx-knots="databridge,handlebars"
+    <script data-knotx-knots="databridge,te"


Can we use change snippet options:

tag name from <script> to <knotx:snippet>

attribute prefix = '', ex. knots="..."

tomaszmichalak · 2018-11-30T09:16:40Z

knotx-it-tests/src/test/resources/content/local/missingServiceConfig.html

@@ -26,7 +26,7 @@
 <body>
 <div class="container-fluid">
    <div class="row">
-        <script data-knotx-knots="databridge,handlebars"
+        <script data-knotx-knots="databridge,te"


Can we limit the html file to this snippet only?

tomaszmichalak · 2018-11-30T09:18:00Z

knotx-it-tests/src/test/resources/content/local/multiple-forms.html

@@ -43,7 +43,7 @@ <h2>
  </div>


Can we limit the html file content?

There are too many changes that are not connected with introducing template engine.
I've created #34 to do them.

tomaszmichalak · 2018-11-30T09:18:26Z

knotx-it-tests/src/test/resources/content/local/noBody.html

@@ -42,7 +42,7 @@ <h2>
    </div>


Can we limit the html file to this snippet only?

tomaszmichalak · 2018-11-30T09:19:27Z

knotx-it-tests/src/test/resources/content/remote/simple.html

@@ -42,7 +42,7 @@ <h2>
    </div>


Do we want to keep the same files in the same once?

malaskowski added 3 commits November 28, 2018 15:50

Replace HBS Knotw with Template Engine

68eb61f

update application config

ffc3877

update integration tests

2f51985

tomaszmichalak requested changes Nov 30, 2018

View reviewed changes

malaskowski added 5 commits November 30, 2018 13:26

Fix SampleApplicationHeadersIntegrationTest

6a9268a

simplify customAndDefaultSymbol.html

fd554d9

make custom delimiter more different

e4977cf

Change default snippetOptions

3248d50

added custom tag it test

500c6f8

malaskowski mentioned this pull request Nov 30, 2018

Cleanup it-tests #34

Closed

tomaszmichalak approved these changes Nov 30, 2018

View reviewed changes

tomaszmichalak merged commit 1cb9f3a into master Nov 30, 2018

tomaszmichalak deleted the feature/switch-to-knotx-template-engine branch November 30, 2018 14:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/switch to knotx template engine #33

Feature/switch to knotx template engine #33

malaskowski commented Nov 29, 2018

tomaszmichalak Nov 30, 2018

tomaszmichalak Nov 30, 2018

tomaszmichalak Nov 30, 2018

malaskowski Nov 30, 2018

tomaszmichalak Nov 30, 2018

tomaszmichalak Nov 30, 2018

tomaszmichalak Nov 30, 2018

malaskowski Nov 30, 2018

tomaszmichalak Nov 30, 2018

tomaszmichalak Nov 30, 2018

		@@ -56,9 +56,7 @@ <h2>Snippet1 - {[_result.message]}</h2>
		<div class="col-md-4">
		<h2>Snippet1 - {[second._result.message]}</h2>

Feature/switch to knotx template engine #33

Feature/switch to knotx template engine #33

Conversation

malaskowski commented Nov 29, 2018

Description

Motivation and Context

Types of changes

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment