Tests cleanup #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaszmichalak
requested changes
Dec 13, 2018
| import org.junit.jupiter.api.Test; | ||
| import org.mockito.Mockito; | ||
|
|
||
| class HandlebarsTemplateEngineTest { |
There was a problem hiding this comment.
Please add the scenarios:
- incorrect syntax,
- empty fragment
There was a problem hiding this comment.
Not sure what you mean by incorrect syntax.
There is already test for spotting delimiters that are not HBS ones (in process_whenCustomDelimiter_expectMarkup).
I've added one more test process_whenUndefinedHbsHelperSpotted_expectMarkup where unknown hbs helper is used.
tomaszmichalak
approved these changes
Dec 18, 2018
| import org.junit.jupiter.api.Test; | ||
| import org.mockito.Mockito; | ||
|
|
||
| class HandlebarsTemplateEngineTest { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests cleanup done together with Knot.x integration tests cleanup.
Motivation and Context
Moved some tests that are internal for this module from
knotx-stack. Added missing unit test.Types of changes
Checklist:
I hereby agree to the terms of the Knot.x Contributor License Agreement.