[Timestampable] Timestamps change regardless of whether something changed #46

Closed
trsteel88 opened this Issue Apr 10, 2013 · 4 comments

Comments

Projects
None yet
3 participants
@trsteel88
Contributor

trsteel88 commented Apr 10, 2013

At the moment, the updated timestamp changes regardless of whether something actually changed in the entity or not.

@PedroTroller

This comment has been minimized.

Show comment
Hide comment
@PedroTroller

PedroTroller Apr 10, 2013

Member

It's added to tests and there is no problem :
https://travis-ci.org/KnpLabs/DoctrineBehaviors/jobs/6211616#L99

Can you be more explicit?

Member

PedroTroller commented Apr 10, 2013

It's added to tests and there is no problem :
https://travis-ci.org/KnpLabs/DoctrineBehaviors/jobs/6211616#L99

Can you be more explicit?

@trsteel88

This comment has been minimized.

Show comment
Hide comment
@trsteel88

trsteel88 Apr 12, 2013

Contributor

Sorry, I didn't make too much sense.

Basically, if you save a form without changing any of the fields, the updated timestamp changes. This should only change if you actually change something in the entity shouldn't it?

Contributor

trsteel88 commented Apr 12, 2013

Sorry, I didn't make too much sense.

Basically, if you save a form without changing any of the fields, the updated timestamp changes. This should only change if you actually change something in the entity shouldn't it?

@docteurklein

This comment has been minimized.

Show comment
Hide comment
@docteurklein

docteurklein Apr 12, 2013

Contributor

yes it should not change if the entity has no changeset. The test pointed above should prove that it actually works as you expect.

Contributor

docteurklein commented Apr 12, 2013

yes it should not change if the entity has no changeset. The test pointed above should prove that it actually works as you expect.

@trsteel88

This comment has been minimized.

Show comment
Hide comment
@trsteel88

trsteel88 Apr 12, 2013

Contributor

Sorry, I found the issue. I had a listener that was modifying a collection.

Contributor

trsteel88 commented Apr 12, 2013

Sorry, I found the issue. I had a listener that was modifying a collection.

@trsteel88 trsteel88 closed this Apr 12, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment