Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop id property from translation trait #421

Closed
wants to merge 1 commit into from

Conversation

@christingruber
Copy link

christingruber commented May 22, 2019

Dropped $id property from translation trait.

Any doctrine entity is shipped with its own $id property. Also, without the $id record inside the trait it is a little bit easier to deal with generated code like symfonys maker bundle or doctrine generator.

Maybe for BC issues, an integration of mapId() is helpful:

private function mapId(ClassMetadata $class, EntityManager $em)

@TomasVotruba

This comment has been minimized.

Copy link
Collaborator

TomasVotruba commented Dec 12, 2019

Thanks, I'll intergrate this feature in #442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.