Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring tests to dependency injection container based + use interfaces over traits for detection #442

Merged
merged 6 commits into from Dec 12, 2019

Conversation

@TomasVotruba
Copy link
Collaborator

TomasVotruba commented Dec 10, 2019

  • Closes #237 - Sluggable as interface
  • Closes #325 - Geocodable as interface
  • Closes #322 - Translatable as interface
  • Closes #242 - Timestampable as interface
  • Closes #324 - Loggable as interface
  • Closes #248 - SoftDeletable as interface
  • Closes #249 - Sortable as interface
  • Closes #246 - Tree as interface

Huge credit for inspiration to @bocharsky-bw and @lemoinem ❤️ who made most of these PRs back in 2015/2016


@TomasVotruba TomasVotruba force-pushed the config-bundle branch 2 times, most recently from ef5caaa to fd7e1e6 Dec 10, 2019
@TomasVotruba TomasVotruba self-assigned this Dec 11, 2019
@TomasVotruba TomasVotruba force-pushed the config-bundle branch 3 times, most recently from a1aab1d to 31d9721 Dec 11, 2019
@TomasVotruba TomasVotruba changed the title [WIP] config bundle [WIP] Refactoring tests to dependency injection container based Dec 11, 2019
@TomasVotruba TomasVotruba force-pushed the config-bundle branch from 8f0ac18 to fdcf0f1 Dec 11, 2019
@TomasVotruba TomasVotruba force-pushed the config-bundle branch 6 times, most recently from 2db02d6 to 3a57200 Dec 11, 2019
@TomasVotruba TomasVotruba force-pushed the config-bundle branch from 48667d5 to 2a9cb22 Dec 12, 2019
@TomasVotruba TomasVotruba changed the title [WIP] Refactoring tests to dependency injection container based Refactoring tests to dependency injection container based + use interfaces over traits Dec 12, 2019
@TomasVotruba TomasVotruba changed the title Refactoring tests to dependency injection container based + use interfaces over traits Refactoring tests to dependency injection container based + use interfaces over traits for detection Dec 12, 2019
@TomasVotruba TomasVotruba force-pushed the config-bundle branch from 2a9cb22 to 4e03209 Dec 12, 2019
@TomasVotruba TomasVotruba merged commit b854c39 into master Dec 12, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@TomasVotruba TomasVotruba deleted the config-bundle branch Dec 12, 2019
@bocharsky-bw

This comment has been minimized.

Copy link
Member

bocharsky-bw commented Dec 12, 2019

Looks like I lost all my credits for those PRs :)

@TomasVotruba

This comment has been minimized.

Copy link
Collaborator Author

TomasVotruba commented Dec 12, 2019

There you go
#442 (comment)

Better merge them right away ;)

@bocharsky-bw

This comment has been minimized.

Copy link
Member

bocharsky-bw commented Dec 13, 2019

I mean PRs were just closed and files re-created from scratch on behalf of you, so no my commits were leaked into the repo :)

Anyway, thanks for integrating this finally

@TomasVotruba

This comment has been minimized.

Copy link
Collaborator Author

TomasVotruba commented Dec 13, 2019

...so no my commits were leaked into the repo :)

Oh no, that was not the reason. I made huge refactoring on adding types in methods and properties, voids, scalars, array etcs., so basically I had to recreate every interface from scratch. Copy-pasting PRs whould take months of rebase time and would not add much value.

I'm sorry if it was put in a wrong way :(

Anyway, thanks for integrating this finally

👍

@TomasVotruba

This comment has been minimized.

Copy link
Collaborator Author

TomasVotruba commented Dec 13, 2019

I've added your name to descrition so you don't feel left out, that's the least I could do.

@bocharsky-bw

This comment has been minimized.

Copy link
Member

bocharsky-bw commented Dec 13, 2019

Ah, I see...

've added your name to descrition so you don't feel left out, that's the least I could do.

Thanks! :)

@lemoinem

This comment has been minimized.

Copy link
Contributor

lemoinem commented Dec 13, 2019

I've just had a bunch of my PRs closed referencing this one as well...
Really glad to see this finally going forward! (:

@TomasVotruba

This comment has been minimized.

Copy link
Collaborator Author

TomasVotruba commented Jan 1, 2020

@lemoinem I've added you to PR description as well. Also I'm writing a post about DoctrineBehaviors 2.0 also with your credit for this feature here.

@lemoinem

This comment has been minimized.

Copy link
Contributor

lemoinem commented Jan 6, 2020

Thank you very much! It's great to see the project moving forward again.
Thank you for taking care of it and keep up the good work :)

@TomasVotruba

This comment has been minimized.

Copy link
Collaborator Author

TomasVotruba commented Jan 6, 2020

Thank you very much! It's great to see the project moving forward again.

It was about the god damned time ;) thanks for never stopping believing! ❤️


I forgot to share it, there you go: https://www.tomasvotruba.cz/blog/2019/12/30/doctrine-behaviors-2-0-reloaded/#from-trait-to-interface

@lemoinem

This comment has been minimized.

Copy link
Contributor

lemoinem commented Jan 6, 2020

Great post!
It's very clear and helps a lot to understand what's going on and the value of the change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.