S3 Adapter can't delete "folders"

[burzum]

S3 does not know folders but you can use keys that mimic folders like /some/folders/myfile.txt.

By looking at the delete method of the S3 adapter you can see it is only deleting a single object. https://github.com/KnpLabs/Gaufrette/blob/master/src/Gaufrette/Adapter/AmazonS3.php#L195

The old version of the AWS SDK Gaufrette is using offers a method delete_all_objects() https://github.com/amazonwebservices/aws-sdk-for-php/blob/master/services/s3.class.php#L2603 which takes wildcards and by this allows you to delete all objects within a given namespace like /some/* would delete /some/folders/myfile.txt.

I propose to change the adapter to check if the given object "isDirectory()" and and if yes call delete_all_objects().

Let me know if you agree and I might create a PR for that.

[jdewit]

+1

[tshafer]

+1

[mtdowling]

Isn't that a really, really dangerous change to make? A simple typo could delete the entire contents of a bucket.

However, I think that Gaufrette should allow you to delete single objects or delete an empty bucket.

[estahn]

@mtdowling I don't see how it is more dangerous than a typo in a usual file system path.

[dogancelik]

I don't know if this is fixed but I vote for it. 👍

[AshleyDawson]

+1

[cuhsat]

+1

[JanisGruzis]

+1

[burzum]

Isn't that a really, really dangerous change to make? A simple typo could delete the entire contents of a bucket.

Oh noes, putting responsibility on the developer! 😨 How do you ever delete a local folder then without getting a heart attack? 😄

[akerouanton]

I think @mtdowling is right: adding a method to delete every objects in a bucket is pretty dangerous. In the other hand I think Filesystem abstraction and underlying adapters are lacking such a feature (deleting multiple objects based on a pattern).

So I would a consider a new method in Filesystem based on a new interface and an opt-in option allow_emptying_buckets for adapters. What do you think?

[estahn]

@NiR- Again, how is it different from deleting a local directory? If we follow that argument i vote for removing the rmdir from the Local Adapter :) ... You have to do the same checks. And @burzum has a good point too.

[burzum]

@NiR- the behaviour across adaptors should be consistent. I think the better way is that any storage system allows deleting of folders / buckets / whatever. If some people are scared simply add a new option that disables deleting of non-empty "folders". This should solve the problem and give people the option instead of forcing a direction.