Provide mime type through the local adapter #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @l3l0 |
|
Hello @gquemener sorry for waiting. PR looks great. I wonder if we should add mimeType method to filesystem as well like in size and checksum case https://github.com/KnpLabs/Gaufrette/blob/master/src/Gaufrette/Filesystem.php#L244 |
|
Hello @l3l0, I saw the FS methods yesterday and I think Gaufrette should provide them to be consistent (but wanted to hear it from you to be sure before implementing them). Let me fix that. |
|
I've renamed |
l3l0
added a commit
that referenced
this pull request
Jun 4, 2014
Provide mime type through the local adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch brings mime type awareness to the local adapter as discussed here: #178 a few months ago.
It allows to smoothly integrate this feature among all the adapters.