Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add algo to checksum #443

Open
wants to merge 2 commits into
base: master
from

Conversation

@IndraGunawan
Copy link

commented Dec 28, 2016

#442


This change is Reviewable

IndraGunawan added some commits Dec 28, 2016

@flug

flug approved these changes Feb 10, 2017

*
* @return string
*/
public function checksum($key);
public function checksum($key, $algo);

This comment has been minimized.

Copy link
@NiR-

NiR- Mar 2, 2017

Member
  • Unfortunately, excluding Local adapter, there are many other places where the change needs to be done
  • It would be a BC break for anyone having an adapter outside of this project
  • It brings a new dependency, hash ext

I'm not against the idea. But I don't think we should do this right now, on master. It might better suite the refacto prepared on split-adapters branch.

@NiR- NiR- added the need rework label Apr 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.