Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VERY][WIP] Introduce collaborators #457

Open
wants to merge 4 commits into
base: master
from

Conversation

@akovalyov
Copy link
Contributor

commented Mar 20, 2015

@wysow this is a very dirty beginning of the approach we have discussed in the #387.
I will try to make it as clean and straightforward as possible (currently it is just dirty initial start).

@pilot pilot added the in progress label Mar 20, 2015

@@ -183,6 +183,7 @@ private function updateContributors(Bundle $bundle)
}
$bundle->setContributors($contributors);

This comment has been minimized.

Copy link
@stof

stof Mar 22, 2015

Contributor

should be reverted

*/
public function addCollaboratedBundle(Bundle $collaboratedBundle)
{
$this->collaboratedBundles[] = $collaboratedBundle;

This comment has been minimized.

Copy link
@stof

stof Mar 22, 2015

Contributor

This implementation is broken: you only update the inverse side of the relation, which means that Doctrine will not persist this change.

And does the relation actually need to be bidirectional ? Unidirectional relations are much easier to reason about and to handle.

@@ -10,7 +10,7 @@
/**
* @author Leszek Prabucki <leszek.prabucki@knplabs.com>
*/
class RepoTest extends \PHPUnit_Framework_TestCase
class TravisTest extends \PHPUnit_Framework_TestCase

This comment has been minimized.

Copy link
@stof

stof Mar 22, 2015

Contributor

you should probably submit this separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.