Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not block adding a repo only if it's name does not validate a too restrictive regex rule #459

Open
wants to merge 1 commit into
base: master
from

Conversation

@wysow
Copy link
Contributor

commented Apr 4, 2015

fixes #458

@wysow wysow added the in progress label Apr 4, 2015

@wysow wysow force-pushed the 458-fully-support-valid-names-of-github-repositories branch from 983c9a6 to 67ea643 Apr 4, 2015

@wysow

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2015

@KnpLabs/knp-team Someone can take a look at this?

@gquemener

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2015

No test to update?

@docteurklein

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2015

lgtm

@wysow

This comment has been minimized.

Copy link
Contributor Author

commented Apr 13, 2015

@gquemener Yep sounds strange but didn't find test about repo name... And as we do not know the valid regex usid by Github, I'm not sure we should add one, what do you think?

@docteurklein

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2015

maybe you can add a test then ?

@wysow

This comment has been minimized.

Copy link
Contributor Author

commented Apr 13, 2015

@docteurklein even if we don't know about the valid regex??

@docteurklein

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2015

just test that it behaves like you want it to behave.
Adding a test wont change the fact it accepts some names only, but it'll help understanding later regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.