Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans to support sf4? #48

Open
sauls opened this issue Mar 19, 2018 · 5 comments

Comments

@sauls
Copy link
Contributor

commented Mar 19, 2018

No description provided.

@yann-eugone

This comment has been minimized.

Copy link

commented Jun 1, 2018

I'm also interested in that support.
I can work on a Pull Request, but I'd like to know if anyone has a todo list for it ?

@weaverryan

This comment has been minimized.

Copy link
Member

commented Jun 1, 2018

Please do open a PR! I would be happy to review and merge it :)

@yann-eugone

This comment has been minimized.

Copy link

commented Jun 4, 2018

I'll try to find some time to work on it this week.
@weaverryan do you already know if there is something that prevent this bundle from being compatible Symfony >= 4.0 ?

@weaverryan

This comment has been minimized.

Copy link
Member

commented Jun 4, 2018

Nothing I know of. But the biggest thing usually is to add public=true on any services that are historically meant to be fetched publicly.

@BorisCharriere

This comment has been minimized.

Copy link

commented Jun 5, 2018

I opened a Pull request for some modification. Fell free to comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.