Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for curl timeout parameter #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

jlaso
Copy link
Contributor

@jlaso jlaso commented Feb 24, 2015

In order to allow slow connections (for instance in my vagrant development) is not enough with the 5 seconds of Buzz/Curl timeout default.

@jlaso
Copy link
Contributor Author

jlaso commented Feb 24, 2015

I change as well the format of the response in case of exception to run the tests


$this->createConfiguration('full');

$this->assertEquals(8, $this->configuration->getParameter('knp_disqus.curl_timeout'));
Copy link
Contributor

@weaverryan weaverryan Feb 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8 is actually equal to Disqus::DEFAULT_TIMEOUT, so it's not the best value to test with

@weaverryan
Copy link
Contributor

weaverryan commented Apr 22, 2016

@jlaso are you still interested in this feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants